Skip to content

Merge to production from development (#17)#18

Merged
devCluna merged 1 commit into
developmentfrom
production
Apr 4, 2026
Merged

Merge to production from development (#17)#18
devCluna merged 1 commit into
developmentfrom
production

Conversation

@devCluna
Copy link
Copy Markdown
Owner

@devCluna devCluna commented Apr 4, 2026

  • main (main #1)

  • ci: add CI workflow with type check, build, verify and dry-run publish

Runs on every push and PR across all branches. Checks:

  • TypeScript (server + admin)
  • Build
  • Strapi plugin verify
  • Version not already published on npm
  • Dry run publish

publish.yml now requires CI to pass before publishing to npm.

  • fix: replace yarn run -T with npx tsc and fix implicit any type errors
  • Fix test:ts:front and test:ts:back scripts to use npx tsc (was yarn-only syntax)
  • Add explicit types for implicit any parameters caught by the type check: MouseEvent on DropZone drag handle click boolean on Modal.Root onOpenChange in EmbedModal and FormPreview string | number on SingleSelect onChange in FieldSettingsPanel and SubmissionsPage
  • ci: add Dependabot for npm and GitHub Actions weekly updates

  • fix: remove stale compiled JS files from src and ignore them in .gitignore

Rollup was resolving register.js (and other compiled .js files) instead of the .ts sources, causing 'default is not exported' build failures in CI. Deleted all .js artifacts from server/src and admin/src and added them to .gitignore so they are never committed again.

  • fix: add --noEmit to tsc type-check scripts to prevent JS file generation

Without --noEmit, tsc outputs .js files next to the .ts sources. Rollup then resolves the CJS .js files instead of the .ts sources and fails with 'default is not exported' on the CommonJS interop boundary.

  • ci: prevent double CI run on PR branches

Push trigger now only fires on main, development and production. Feature branches are covered by the pull_request trigger alone, so CI no longer runs twice when pushing to an open PR.

Runs on every push and PR across all branches. Checks:

  • TypeScript (server + admin)
  • Build
  • Strapi plugin verify
  • Version not already published on npm
  • Dry run publish

publish.yml now requires CI to pass before publishing to npm.

  • fix: replace yarn run -T with npx tsc and fix implicit any type errors
  • Fix test:ts:front and test:ts:back scripts to use npx tsc (was yarn-only syntax)
  • Add explicit types for implicit any parameters caught by the type check: MouseEvent on DropZone drag handle click boolean on Modal.Root onOpenChange in EmbedModal and FormPreview string | number on SingleSelect onChange in FieldSettingsPanel and SubmissionsPage
  • ci: add Dependabot for npm and GitHub Actions weekly updates

  • fix: remove stale compiled JS files from src and ignore them in .gitignore

Rollup was resolving register.js (and other compiled .js files) instead of the .ts sources, causing 'default is not exported' build failures in CI. Deleted all .js artifacts from server/src and admin/src and added them to .gitignore so they are never committed again.

  • fix: add --noEmit to tsc type-check scripts to prevent JS file generation

Without --noEmit, tsc outputs .js files next to the .ts sources. Rollup then resolves the CJS .js files instead of the .ts sources and fails with 'default is not exported' on the CommonJS interop boundary.

  • ci: prevent double CI run on PR branches

Push trigger now only fires on main, development and production. Feature branches are covered by the pull_request trigger alone, so CI no longer runs twice when pushing to an open PR.

  • 📝 Add docstrings to main

Docstrings generation was requested by @devCluna.

The following files were modified:

  • admin/src/components/DropZone.tsx
  • admin/src/components/EmbedModal.tsx
  • admin/src/components/FieldSettingsPanel.tsx
  • admin/src/components/FormPreview.tsx
  • admin/src/pages/SubmissionsPage.tsx


Summary by CodeRabbit

  • Documentation

    • Updated repository URL reference in getting started instructions.
  • Chores

    • Enhanced CI/CD pipeline configuration to include continuous integration verification step.

* main (#1)

* ci: add CI workflow with type check, build, verify and dry-run publish

Runs on every push and PR across all branches. Checks:
- TypeScript (server + admin)
- Build
- Strapi plugin verify
- Version not already published on npm
- Dry run publish

publish.yml now requires CI to pass before publishing to npm.

* fix: replace yarn run -T with npx tsc and fix implicit any type errors

- Fix test:ts:front and test:ts:back scripts to use npx tsc (was yarn-only syntax)
- Add explicit types for implicit any parameters caught by the type check:
  MouseEvent on DropZone drag handle click
  boolean on Modal.Root onOpenChange in EmbedModal and FormPreview
  string | number on SingleSelect onChange in FieldSettingsPanel and SubmissionsPage

* ci: add Dependabot for npm and GitHub Actions weekly updates

* fix: remove stale compiled JS files from src and ignore them in .gitignore

Rollup was resolving register.js (and other compiled .js files) instead
of the .ts sources, causing 'default is not exported' build failures in CI.
Deleted all .js artifacts from server/src and admin/src and added them
to .gitignore so they are never committed again.

* fix: add --noEmit to tsc type-check scripts to prevent JS file generation

Without --noEmit, tsc outputs .js files next to the .ts sources.
Rollup then resolves the CJS .js files instead of the .ts sources and
fails with 'default is not exported' on the CommonJS interop boundary.

* ci: prevent double CI run on PR branches

Push trigger now only fires on main, development and production.
Feature branches are covered by the pull_request trigger alone,
so CI no longer runs twice when pushing to an open PR.

* 📝 Add docstrings to `main` (#2)

* ci: add CI workflow with type check, build, verify and dry-run publish

Runs on every push and PR across all branches. Checks:
- TypeScript (server + admin)
- Build
- Strapi plugin verify
- Version not already published on npm
- Dry run publish

publish.yml now requires CI to pass before publishing to npm.

* fix: replace yarn run -T with npx tsc and fix implicit any type errors

- Fix test:ts:front and test:ts:back scripts to use npx tsc (was yarn-only syntax)
- Add explicit types for implicit any parameters caught by the type check:
  MouseEvent on DropZone drag handle click
  boolean on Modal.Root onOpenChange in EmbedModal and FormPreview
  string | number on SingleSelect onChange in FieldSettingsPanel and SubmissionsPage

* ci: add Dependabot for npm and GitHub Actions weekly updates

* fix: remove stale compiled JS files from src and ignore them in .gitignore

Rollup was resolving register.js (and other compiled .js files) instead
of the .ts sources, causing 'default is not exported' build failures in CI.
Deleted all .js artifacts from server/src and admin/src and added them
to .gitignore so they are never committed again.

* fix: add --noEmit to tsc type-check scripts to prevent JS file generation

Without --noEmit, tsc outputs .js files next to the .ts sources.
Rollup then resolves the CJS .js files instead of the .ts sources and
fails with 'default is not exported' on the CommonJS interop boundary.

* ci: prevent double CI run on PR branches

Push trigger now only fires on main, development and production.
Feature branches are covered by the pull_request trigger alone,
so CI no longer runs twice when pushing to an open PR.

* 📝 Add docstrings to `main`

Docstrings generation was requested by @devCluna.

* #1 (comment)

The following files were modified:

* `admin/src/components/DropZone.tsx`
* `admin/src/components/EmbedModal.tsx`
* `admin/src/components/FieldSettingsPanel.tsx`
* `admin/src/components/FormPreview.tsx`
* `admin/src/pages/SubmissionsPage.tsx`

---------

Co-authored-by: dev.cluna <dev.cluna@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Fix GitHub repository URL in README (#16)

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@devCluna devCluna merged commit 231342b into development Apr 4, 2026
1 of 4 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 4, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 913fb260-1d0f-4053-b054-ce5b6f66f902

📥 Commits

Reviewing files that changed from the base of the PR and between dfc7e34 and 5b52530.

📒 Files selected for processing (2)
  • .github/workflows/publish.yml
  • README.md

📝 Walkthrough

Walkthrough

Updated the GitHub repository username from dev-cluna to devCluna in the README clone example. Added a CI job to the publish workflow that reuses the configuration from ./.github/workflows/ci.yml.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/publish.yml
Added a new ci job that reuses the workflow defined in ./.github/workflows/ci.yml. No modifications to existing publish steps, versioning, npm publishing, or release creation logic.
Documentation
README.md
Updated the example git clone command to reflect the corrected GitHub username casing (dev-clunadevCluna).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • main #1: Directly related—both PRs add the same ci job delegation to ./.github/workflows/ci.yml in the publish workflow.
  • Fix GitHub repository URL in README #16: Related—both PRs update the README clone URL with the corrected username casing.

Suggested labels

enhancement

Poem

🐰 A username fix, so clean and neat,
With CI workflows now complete,
The rabbit hops with joy and cheer,
For better workflows now are here! 🌱

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch production

Comment @coderabbitai help to get the list of available commands and usage tips.

@devCluna devCluna deleted the production branch April 4, 2026 12:33
@devCluna devCluna restored the production branch April 4, 2026 12:33
devCluna added a commit that referenced this pull request Apr 4, 2026
* main (#1)

* ci: add CI workflow with type check, build, verify and dry-run publish

Runs on every push and PR across all branches. Checks:
- TypeScript (server + admin)
- Build
- Strapi plugin verify
- Version not already published on npm
- Dry run publish

publish.yml now requires CI to pass before publishing to npm.

* fix: replace yarn run -T with npx tsc and fix implicit any type errors

- Fix test:ts:front and test:ts:back scripts to use npx tsc (was yarn-only syntax)
- Add explicit types for implicit any parameters caught by the type check:
  MouseEvent on DropZone drag handle click
  boolean on Modal.Root onOpenChange in EmbedModal and FormPreview
  string | number on SingleSelect onChange in FieldSettingsPanel and SubmissionsPage

* ci: add Dependabot for npm and GitHub Actions weekly updates

* fix: remove stale compiled JS files from src and ignore them in .gitignore

Rollup was resolving register.js (and other compiled .js files) instead
of the .ts sources, causing 'default is not exported' build failures in CI.
Deleted all .js artifacts from server/src and admin/src and added them
to .gitignore so they are never committed again.

* fix: add --noEmit to tsc type-check scripts to prevent JS file generation

Without --noEmit, tsc outputs .js files next to the .ts sources.
Rollup then resolves the CJS .js files instead of the .ts sources and
fails with 'default is not exported' on the CommonJS interop boundary.

* ci: prevent double CI run on PR branches

Push trigger now only fires on main, development and production.
Feature branches are covered by the pull_request trigger alone,
so CI no longer runs twice when pushing to an open PR.

* 📝 Add docstrings to `main` (#2)

* ci: add CI workflow with type check, build, verify and dry-run publish

Runs on every push and PR across all branches. Checks:
- TypeScript (server + admin)
- Build
- Strapi plugin verify
- Version not already published on npm
- Dry run publish

publish.yml now requires CI to pass before publishing to npm.

* fix: replace yarn run -T with npx tsc and fix implicit any type errors

- Fix test:ts:front and test:ts:back scripts to use npx tsc (was yarn-only syntax)
- Add explicit types for implicit any parameters caught by the type check:
  MouseEvent on DropZone drag handle click
  boolean on Modal.Root onOpenChange in EmbedModal and FormPreview
  string | number on SingleSelect onChange in FieldSettingsPanel and SubmissionsPage

* ci: add Dependabot for npm and GitHub Actions weekly updates

* fix: remove stale compiled JS files from src and ignore them in .gitignore

Rollup was resolving register.js (and other compiled .js files) instead
of the .ts sources, causing 'default is not exported' build failures in CI.
Deleted all .js artifacts from server/src and admin/src and added them
to .gitignore so they are never committed again.

* fix: add --noEmit to tsc type-check scripts to prevent JS file generation

Without --noEmit, tsc outputs .js files next to the .ts sources.
Rollup then resolves the CJS .js files instead of the .ts sources and
fails with 'default is not exported' on the CommonJS interop boundary.

* ci: prevent double CI run on PR branches

Push trigger now only fires on main, development and production.
Feature branches are covered by the pull_request trigger alone,
so CI no longer runs twice when pushing to an open PR.

* 📝 Add docstrings to `main`

Docstrings generation was requested by @devCluna.

* #1 (comment)

The following files were modified:

* `admin/src/components/DropZone.tsx`
* `admin/src/components/EmbedModal.tsx`
* `admin/src/components/FieldSettingsPanel.tsx`
* `admin/src/components/FormPreview.tsx`
* `admin/src/pages/SubmissionsPage.tsx`

---------




* Fix GitHub repository URL in README (#16)

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant