Skip to content

Commit 03ad99e

Browse files
committed
stop creating Product_Type_Member in classic add_product_type view
Drop the inline Product_Type_Member.objects.create call from dojo/product_type/views.py:add_product_type. Pro's post_save signal on Product_Type bootstraps the Owner row for the requesting user. Drop the Product_Type_Member and Role imports since this was the last consumer in this module.
1 parent bcab3be commit 03ad99e

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

dojo/product_type/views.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
from django.utils.translation import gettext as _
1515

1616
from dojo.authorization.authorization import user_has_permission_or_403
17-
from dojo.authorization.models import Product_Type_Member, Role
1817
from dojo.authorization.roles_permissions import Permissions
1918
from dojo.filters import ProductFilter, ProductFilterWithoutObjectLookups, ProductTypeFilter
2019
from dojo.forms import (
@@ -96,12 +95,7 @@ def add_product_type(request):
9695
if request.method == "POST":
9796
form = Product_TypeForm(request.POST)
9897
if form.is_valid():
99-
product_type = form.save()
100-
member = Product_Type_Member()
101-
member.user = request.user
102-
member.product_type = product_type
103-
member.role = Role.objects.get(is_owner=True)
104-
member.save()
98+
form.save()
10599
messages.add_message(request,
106100
messages.SUCCESS,
107101
str(labels.ORG_CREATE_SUCCESS_MESSAGE),

0 commit comments

Comments
 (0)