Skip to content

Commit 932b0cd

Browse files
committed
strip Global_Role check from finding_group ListFindingGroups
Remove the Global_Role lookup that decided whether the requesting user sees all finding groups or only those for authorized products. The remaining branch (is_superuser sees all, else filter by authorized products) covers OS's access model. Pro can re-introduce richer gating in its own override if needed.
1 parent a646563 commit 932b0cd

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

dojo/finding_group/views.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
from django.views.decorators.http import require_POST
1414

1515
from dojo.authorization.authorization import user_has_permission_or_403
16-
from dojo.authorization.models import Global_Role
1716
from dojo.filters import (
1817
FindingFilter,
1918
FindingFilterWithoutObjectLookups,
@@ -294,9 +293,8 @@ def paginate_queryset(self, queryset: QuerySet[Finding_Group], request: HttpRequ
294293
return paginator.get_page(page_number)
295294

296295
def get(self, request: HttpRequest) -> HttpResponse:
297-
global_role = Global_Role.objects.filter(user=request.user).first()
298296
products = get_authorized_products("view")
299-
if request.user.is_superuser or (global_role and global_role.role):
297+
if request.user.is_superuser:
300298
finding_groups = self.get_finding_groups(request)
301299
elif products.exists():
302300
finding_groups = self.get_finding_groups(request, products)

0 commit comments

Comments
 (0)