fix: enable share image generation for repo analysis pages

ShareActions was passing jobId as the userId path param, causing 404s.
Now passes userId separately and appends ?jobId= to API URLs. The OG
share route supports jobId by fetching from vibe_insights and
analysis_jobs instead of user_profiles.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: devakone

apps/web/src/app/analysis/[jobId]/AnalysisClient.tsx

@@ -846,6 +846,7 @@ export default function AnalysisClient({ jobId }: { jobId: string }) {
                 shareHeadline={shareTemplate.headline}
                 shareTemplate={shareImageTemplate}
                 entityId={jobId}
+                userId={data?.userId ?? undefined}
                 storyEndpoint={storyEndpoint}
               />
             </div>

apps/web/src/app/api/share/[format]/[userId]/route.tsx

@@ -11,7 +11,8 @@ export async function GET(
 ) {
   try {
     const { format, userId } = await params;
-    
+    const jobId = new URL(request.url).searchParams.get("jobId");
+
     if (!["og", "square", "story"].includes(format)) {
       return new Response("Invalid format", { status: 400 });
     }
@@ -60,21 +61,73 @@ export async function GET(
 
     const supabase = createClient(supabaseUrl, supabaseKey);
 
-    // Fetch Profile
-    const { data: profile, error } = await supabase
-      .from("user_profiles")
-      .select("persona_id, persona_name, persona_tagline, persona_confidence, total_repos, total_commits, axes_json, narrative_json")
-      .eq("user_id", userId)
-      .maybeSingle();
+    // Fetch data: job-specific or unified profile
+    let profile: {
+      persona_id: string;
+      persona_name: string | null;
+      persona_tagline: string | null;
+      persona_confidence: string | null;
+      total_repos: number | null;
+      total_commits: number | null;
+      axes_json: Record<string, { score: number }> | null;
+      narrative_json: { insight?: string; summary?: string } | null;
+    } | null = null;
+
+    if (jobId) {
+      // Job-specific share: fetch from vibe_insights + analysis_jobs
+      const [vibeResult, jobResult, insightsResult] = await Promise.all([
+        supabase
+          .from("vibe_insights")
+          .select("persona_id, persona_name, persona_tagline, persona_confidence, axes_json")
+          .eq("job_id", jobId)
+          .maybeSingle(),
+        supabase
+          .from("analysis_jobs")
+          .select("commit_count")
+          .eq("id", jobId)
+          .eq("user_id", userId)
+          .maybeSingle(),
+        supabase
+          .from("analysis_insights")
+          .select("persona_label, persona_confidence, persona_id, narrative_json")
+          .eq("job_id", jobId)
+          .maybeSingle(),
+      ]);
 
-    if (error) {
-      console.error("Supabase error:", error);
-      throw new Error(`Profile fetch failed: ${error.message}`);
+      const vibe = vibeResult.data;
+      const job = jobResult.data;
+      const insights = insightsResult.data;
+
+      if (vibe || insights) {
+        profile = {
+          persona_id: vibe?.persona_id ?? insights?.persona_id ?? "balanced_builder",
+          persona_name: vibe?.persona_name ?? insights?.persona_label ?? null,
+          persona_tagline: vibe?.persona_tagline ?? null,
+          persona_confidence: vibe?.persona_confidence ?? insights?.persona_confidence ?? null,
+          total_repos: 1,
+          total_commits: job?.commit_count ?? null,
+          axes_json: vibe?.axes_json ?? null,
+          narrative_json: insights?.narrative_json ?? null,
+        };
+      }
+    } else {
+      // Unified profile share
+      const { data, error } = await supabase
+        .from("user_profiles")
+        .select("persona_id, persona_name, persona_tagline, persona_confidence, total_repos, total_commits, axes_json, narrative_json")
+        .eq("user_id", userId)
+        .maybeSingle();
+
+      if (error) {
+        console.error("Supabase error:", error);
+        throw new Error(`Profile fetch failed: ${error.message}`);
+      }
+      profile = data;
     }
-    
+
     if (!profile) {
-      console.error(`Profile not found for userId: ${userId}`);
-      return new Response("Profile not found - check if userId is correct or if RLS policies prevent access (Service Role Key required for private profiles)", { status: 404 });
+      console.error(`Profile not found for userId: ${userId}${jobId ? `, jobId: ${jobId}` : ""}`);
+      return new Response("Profile not found", { status: 404 });
     }
 
     // Prepare Data

apps/web/src/components/share/ShareActions.tsx

@@ -46,9 +46,13 @@ export function ShareActions({
   shareHeadline,
   shareTemplate,
   entityId,
+  userId,
   disabled = false,
   shareJson,
 }: ShareActionsProps) {
+  // When userId is provided, use it as the path param and append jobId query
+  const shareApiId = userId ?? entityId;
+  const shareApiQuery = userId ? `?jobId=${entityId}` : "";
   const [copied, setCopied] = useState(false);
   const [copiedLink, setCopiedLink] = useState(false);
   const [shareFormat, setShareFormat] = useState<ShareFormat>("og");
@@ -134,7 +138,7 @@ export function ShareActions({
 
     try {
       // 2. Fetch the image blob
-      const url = `/api/share/${shareFormat}/${entityId}`;
+      const url = `/api/share/${shareFormat}/${shareApiId}${shareApiQuery}`;
       const res = await fetch(url);
       if (!res.ok) throw new Error("generation_failed");
       const blob = await res.blob();
@@ -182,7 +186,7 @@ export function ShareActions({
     setDownloading(true);
     try {
       // Use the new backend API for consistent image generation
-      const url = `/api/share/${shareFormat}/${entityId}`;
+      const url = `/api/share/${shareFormat}/${shareApiId}${shareApiQuery}`;
       const res = await fetch(url);
       if (!res.ok) throw new Error("generation_failed");
       const blob = await res.blob();
@@ -202,7 +206,7 @@ export function ShareActions({
     setStoryDownloading(true);
     try {
       // Use the new backend API for story generation
-      const url = `/api/share/story/${entityId}`;
+      const url = `/api/share/story/${shareApiId}${shareApiQuery}`;
       const res = await fetch(url);
       if (!res.ok) throw new Error("story_failed");
       const blob = await res.blob();

apps/web/src/components/share/types.ts

@@ -57,6 +57,8 @@ export interface ShareActionsProps {
   shareTemplate: ShareImageTemplate | null;
   /** Job ID or profile ID for filename */
   entityId: string;
+  /** User ID for share API routes (when entityId is a jobId) */
+  userId?: string;
   /** Whether share is disabled */
   disabled?: boolean;
   /** Optional story download endpoint */