Skip to content

Commit 069337c

Browse files
committed
feat: Add a new section outlining the code review protocol and checklist.
1 parent 3ed9838 commit 069337c

1 file changed

Lines changed: 31 additions & 0 deletions

File tree

Agents.md

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -506,6 +506,37 @@ MCP Supabase tools connect to remote projects, not local. For local development:
506506
- **Keep PRD.md current** if requirements change
507507
- **This file (Agents.md)** is the source of truth for agent behavior
508508

509+
510+
## Code Review Protocol
511+
512+
When reviewing code or PRs, apply deep analysis ("ultrathink") to validate reasonableness:
513+
514+
### 1. Plan/PRD Validation
515+
- **Check alignment**: Does the code match the plan or PRD?
516+
- **Identify gaps**: What will NOT work? What will break?
517+
- **Surface oversights**: What was overlooked or not considered?
518+
- **Edge cases**: Are all edge cases handled?
519+
520+
### 2. Simplification Analysis
521+
- **Reduce complexity**: Is there a simpler approach that achieves the same outcome?
522+
- **Remove redundancy**: Are there unnecessary abstractions or indirections?
523+
- **Question scope**: Is the change doing more than required?
524+
525+
### 3. Regression Risk Assessment
526+
- **Existing functionality**: Will this break current behavior?
527+
- **Dependent code**: What other code relies on the modified paths?
528+
- **Test coverage**: Are existing tests still valid? Do they need updates?
529+
- **Backward compatibility**: Are APIs/interfaces preserved or properly versioned?
530+
531+
### Review Checklist
532+
- [ ] Code matches PRD/plan intent
533+
- [ ] No obvious failure modes overlooked
534+
- [ ] Simplest reasonable approach used
535+
- [ ] No unnecessary scope creep
536+
- [ ] Existing tests still pass
537+
- [ ] New tests cover changed behavior
538+
- [ ] No breaking changes to existing functionality (or documented if intentional)
539+
509540
---
510541

511542
*Last updated: 2026-01-22*

0 commit comments

Comments
 (0)