Fix installer pipe execution and upgrade extraction failures

- Installer now works when piped via curl | bash - detects pipe execution and saves to temp file before re-executing
- Fix upgrade command marker mismatch: __SHIPNODE_PAYLOAD__ → __ARCHIVE_BELOW__
- Fix upgrade extraction paths to account for shipnode/ subdirectory in archive

Author: devalade

build-dist.sh

@@ -59,6 +59,16 @@ cat > "$DIST_DIR/$INSTALLER_NAME" << 'EOF'
 
 set -e
 
+# Detect pipe execution and save to temp file
+if [ ! -f "$0" ] || [ "$(basename "$0")" = "bash" ] || [ "$(basename "$0")" = "sh" ]; then
+    SELF_TEMP=$(mktemp)
+    cat > "$SELF_TEMP"
+    bash "$SELF_TEMP" "$@"
+    EXIT_CODE=$?
+    rm -f "$SELF_TEMP"
+    exit $EXIT_CODE
+fi
+
 # Colors
 RED='\033[0;31m'
 GREEN='\033[0;32m'
@@ -85,19 +95,20 @@ done
 # Extract embedded archive
 echo -e "${BLUE}→${NC} Extracting ShipNode..."
 
-# Get absolute path of this script before changing directory (portable for Linux and macOS)
-if command -v realpath &> /dev/null; then
-    SCRIPT_PATH="$(realpath "$0")"
+# Get absolute path of this script (after pipe detection, $0 is always a real file)
+if command -v readlink &> /dev/null && readlink -f "$0" &> /dev/null; then
+    # Linux: use readlink -f
+    SCRIPT_PATH="$(readlink -f "$0")"
 elif [[ "$OSTYPE" == "darwin"* ]]; then
-    # macOS: construct absolute path manually since readlink -f doesn't exist
+    # macOS: readlink -f doesn't exist, construct absolute path manually
     if [ -L "$0" ]; then
         SCRIPT_PATH="$(cd "$(dirname "$0")" && cd "$(dirname "$(readlink "$0")")" && pwd)/$(basename "$(readlink "$0")")"
     else
         SCRIPT_PATH="$(cd "$(dirname "$0")" && pwd)/$(basename "$0")"
     fi
 else
-    # Linux: use readlink -f
-    SCRIPT_PATH="$(readlink -f "$0")"
+    # Fallback
+    SCRIPT_PATH="$(cd "$(dirname "$0")" && pwd)/$(basename "$0")"
 fi
 
 # Create temp directory

lib/commands/upgrade.sh

@@ -55,9 +55,9 @@ cmd_upgrade() {
     # Extract the installer (it's a self-extracting script)
     info "Extracting installer..."
 
-    # The installer has a base64 payload after __SHIPNODE_PAYLOAD__ marker
+    # The installer has a base64 payload after __ARCHIVE_BELOW__ marker
     # Extract and decode it
-    local payload_marker="__SHIPNODE_PAYLOAD__"
+    local payload_marker="__ARCHIVE_BELOW__"
     local payload_start
     payload_start=$(grep -n "^${payload_marker}$" "$temp_dir/shipnode-installer.sh" | head -n1 | cut -d: -f1)
 
@@ -73,22 +73,22 @@ cmd_upgrade() {
         error "Failed to extract installer payload"
     fi
 
-    # Verify extraction
-    if [ ! -f "$temp_dir/shipnode" ] || [ ! -d "$temp_dir/lib" ]; then
+    # Verify extraction (tar extracts into shipnode/ subdirectory)
+    if [ ! -f "$temp_dir/shipnode/shipnode" ] || [ ! -d "$temp_dir/shipnode/lib" ]; then
         rm -rf "$temp_dir"
         error "Extracted files are incomplete"
     fi
 
     # Install to SHIPNODE_DIR (overwrite existing installation)
     info "Installing to $SHIPNODE_DIR..."
 
-    # Copy files
-    cp -r "$temp_dir/shipnode" "$SHIPNODE_DIR/" || {
+    # Copy files from the extracted shipnode/ subdirectory
+    cp -r "$temp_dir/shipnode/shipnode" "$SHIPNODE_DIR/" || {
         rm -rf "$temp_dir"
         error "Failed to copy shipnode entry point"
     }
 
-    cp -r "$temp_dir/lib" "$SHIPNODE_DIR/" || {
+    cp -r "$temp_dir/shipnode/lib" "$SHIPNODE_DIR/" || {
         rm -rf "$temp_dir"
         error "Failed to copy lib directory"
     }