Fix database password and runtime diagnostics

Author: devalade

build-dist.sh

@@ -7,7 +7,7 @@ GREEN='\033[0;32m'
 BLUE='\033[0;34m'
 NC='\033[0m'
 
-VERSION="1.4.6"
+VERSION="1.4.7"
 DIST_DIR="dist"
 ARCHIVE_NAME="shipnode-payload.tar.gz"
 INSTALLER_NAME="shipnode-installer.sh"
@@ -90,7 +90,7 @@ YELLOW='\033[1;33m'
 BLUE='\033[0;34m'
 NC='\033[0m'
 
-VERSION="1.4.6"
+VERSION="1.4.7"
 INSTALL_DIR="$HOME/.shipnode"
 
 # Parse flags

install.sh

@@ -10,7 +10,7 @@ BLUE='\033[0;34m'
 NC='\033[0m'
 
 echo -e "${BLUE}╔════════════════════════════════════╗${NC}"
-echo -e "${BLUE}║     ShipNode Installer v1.4.6      ║${NC}"
+echo -e "${BLUE}║     ShipNode Installer v1.4.7      ║${NC}"
 echo -e "${BLUE}╚════════════════════════════════════╝${NC}"
 echo
 

lib/commands/doctor.sh

@@ -233,20 +233,32 @@ check_remote_environment() {
 
     local ssh_port="${SSH_PORT:-22}"
     local pkg_manager=$(detect_pkg_manager)
+    local node_version="${NODE_VERSION:-24}"
+    [ "$node_version" = "lts" ] && node_version="24"
 
     # Single batched SSH call for all remote checks
     local remote_output
-    remote_output=$(remote_exec bash << 'REMOTE_CHECKS'
+    remote_output=$(remote_exec bash -s "$node_version" "$pkg_manager" << 'REMOTE_CHECKS'
+        NODE_VERSION="$1"
+        PKG_MANAGER="$2"
+        export PATH="$HOME/.local/bin:$HOME/.local/share/mise/shims:$PATH"
+
+        if command -v mise &> /dev/null; then
+            echo "RUNTIME_OK:$(mise --version | head -n1)"
+        else
+            echo "RUNTIME_MISSING"
+        fi
+
         # Check node
-        if command -v node &> /dev/null; then
-            echo "NODE_OK:$(node --version)"
+        if command -v mise &> /dev/null && mise exec "node@$NODE_VERSION" -- node --version &> /dev/null; then
+            echo "NODE_OK:$(mise exec "node@$NODE_VERSION" -- node --version)"
         else
             echo "NODE_MISSING"
         fi
 
         # Check PM2
-        if command -v pm2 &> /dev/null; then
-            echo "PM2_OK:$(pm2 --version)"
+        if command -v mise &> /dev/null && mise exec "node@$NODE_VERSION" -- pm2 --version &> /dev/null; then
+            echo "PM2_OK:$(mise exec "node@$NODE_VERSION" -- pm2 --version)"
         else
             echo "PM2_MISSING"
         fi
@@ -265,16 +277,32 @@ check_remote_environment() {
         echo "DISK:$disk_avail"
 
         # Check package managers
-        command -v npm &> /dev/null && echo "PKG_NPM_OK"
-        command -v yarn &> /dev/null && echo "PKG_YARN_OK"
-        command -v pnpm &> /dev/null && echo "PKG_PNPM_OK"
-        command -v bun &> /dev/null && echo "PKG_BUN_OK"
+        if [ "$PKG_MANAGER" = "bun" ]; then
+            command -v bun &> /dev/null && echo "PKG_BUN_OK"
+            [ -x "$HOME/.bun/bin/bun" ] && echo "PKG_BUN_OK"
+        elif command -v mise &> /dev/null && mise exec "node@$NODE_VERSION" -- "$PKG_MANAGER" --version &> /dev/null; then
+            if [ "$PKG_MANAGER" = "npm" ]; then
+                echo "PKG_NPM_OK"
+            elif [ "$PKG_MANAGER" = "yarn" ]; then
+                echo "PKG_YARN_OK"
+            elif [ "$PKG_MANAGER" = "pnpm" ]; then
+                echo "PKG_PNPM_OK"
+            fi
+        fi
 REMOTE_CHECKS
     )
 
     local has_errors=false
 
     # Parse node check
+    if echo "$remote_output" | grep -q "RUNTIME_OK:"; then
+        local runtime_version=$(echo "$remote_output" | grep "RUNTIME_OK:" | cut -d: -f2-)
+        echo "  ✓ per-project runtime available ($runtime_version)"
+    else
+        echo "  ✗ per-project runtime not found (run: shipnode setup)"
+        has_errors=true
+    fi
+
     if echo "$remote_output" | grep -q "NODE_OK:"; then
         local node_version=$(echo "$remote_output" | grep "NODE_OK:" | cut -d: -f2)
         echo "  ✓ node available ($node_version)"

lib/core.sh

@@ -10,7 +10,7 @@ BLUE='\033[0;34m'
 NC='\033[0m' # No Color
 
 # ShipNode version
-VERSION="1.4.6"
+VERSION="1.4.7"
 
 # SSH multiplexing for connection reuse
 SSH_CONTROL_PATH="/tmp/shipnode-ssh-%r@%h:%p"

lib/database.sh

@@ -9,6 +9,14 @@ validate_db_identifier() {
 }
 
 setup_databases() {
+	if [ -z "${DB_PASSWORD:-}" ] && [ -n "${DATABASE_URL:-}" ]; then
+		local db_url_auth="${DATABASE_URL#*://}"
+		db_url_auth="${db_url_auth%%@*}"
+		if [[ "$db_url_auth" == *:* ]]; then
+			DB_PASSWORD="${db_url_auth#*:}"
+		fi
+	fi
+
 	if [ "${DB_SETUP_ENABLED:-false}" = "true" ]; then
 		case "${DB_TYPE:-postgresql}" in
 			postgresql|postgres|pg)
@@ -35,7 +43,7 @@ setup_databases() {
 setup_postgresql() {
 	# Validate required variables
 	if [ -z "$DB_NAME" ] || [ -z "$DB_USER" ] || [ -z "$DB_PASSWORD" ]; then
-		warn "PostgreSQL setup enabled but DB_NAME, DB_USER, or DB_PASSWORD not set in config"
+		warn "PostgreSQL setup enabled but DB_NAME, DB_USER, or DB_PASSWORD is missing. Set DB_PASSWORD in .env or shipnode.conf."
 		return 1
 	fi
 
@@ -119,7 +127,7 @@ ENDSSH
 
 setup_mysql() {
 	if [ -z "$DB_NAME" ] || [ -z "$DB_USER" ] || [ -z "$DB_PASSWORD" ]; then
-		warn "MySQL setup enabled but DB_NAME, DB_USER, or DB_PASSWORD not set in config"
+		warn "MySQL setup enabled but DB_NAME, DB_USER, or DB_PASSWORD is missing. Set DB_PASSWORD in .env or shipnode.conf."
 		return 1
 	fi