Skip to content

Commit 67ec90e

Browse files
authored
Fix/fix build pipeline (#20)
* feat: optimize PNPM setup by skipping install and updating PATH in workflows * fix: update PNPM installation and caching in workflows * fix: add explicit permissions for creating releases in workflow * fix: update asset paths to handle spaces in filenames and add verification for release-assets * fix: improve artifact handling in release workflow and update asset paths
1 parent 86f7bdc commit 67ec90e

1 file changed

Lines changed: 20 additions & 7 deletions

File tree

.github/workflows/release.yml

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,11 @@ jobs:
6666
needs: [check-version, build]
6767
if: needs.check-version.outputs.should_release == 'true'
6868
runs-on: ubuntu-latest
69+
# Add explicit permissions for creating releases
70+
permissions:
71+
contents: write
72+
issues: write
73+
pull-requests: write
6974
steps:
7075
- name: Checkout repository
7176
uses: actions/checkout@v4
@@ -100,9 +105,17 @@ jobs:
100105
- name: Generate update JSON
101106
run: |
102107
mkdir -p release-assets
103-
cp artifacts/circle-camera-macos-aarch64/*.dmg release-assets/
104-
cp artifacts/circle-camera-macos-x64/*.dmg release-assets/
105-
# Windows asset copy is removed as it's not supported
108+
109+
# Debug: Show what artifacts we have
110+
echo "Contents of artifacts directory:"
111+
find artifacts -type f -name "*.dmg" | sort
112+
113+
# Copy DMG files from artifacts directory
114+
find artifacts -type f -name "*.dmg" -exec cp {} release-assets/ \;
115+
116+
# List the actual files to verify the names
117+
echo "Files in release-assets directory:"
118+
ls -la release-assets/
106119
107120
# Generate latest.json
108121
node ./scripts/generate-update-json.js
@@ -145,8 +158,8 @@ jobs:
145158
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
146159
with:
147160
upload_url: ${{ steps.create_release.outputs.upload_url }}
148-
asset_path: ./release-assets/Circle.Camera_${{ needs.check-version.outputs.version }}_aarch64.dmg
149-
asset_name: Circle.Camera_${{ needs.check-version.outputs.version }}_aarch64.dmg
161+
asset_path: "./artifacts/circle-camera-macos-aarch64/Circle Camera_${{ needs.check-version.outputs.version }}_aarch64.dmg"
162+
asset_name: "Circle Camera_${{ needs.check-version.outputs.version }}_aarch64.dmg"
150163
asset_content_type: application/octet-stream
151164

152165
- name: Upload macOS Intel Asset
@@ -155,8 +168,8 @@ jobs:
155168
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
156169
with:
157170
upload_url: ${{ steps.create_release.outputs.upload_url }}
158-
asset_path: ./release-assets/Circle.Camera_${{ needs.check-version.outputs.version }}_x64.dmg
159-
asset_name: Circle.Camera_${{ needs.check-version.outputs.version }}_x64.dmg
171+
asset_path: "./artifacts/circle-camera-macos-x64/Circle Camera_${{ needs.check-version.outputs.version }}_x64.dmg"
172+
asset_name: "Circle Camera_${{ needs.check-version.outputs.version }}_x64.dmg"
160173
asset_content_type: application/octet-stream
161174

162175
- name: Upload latest.json Asset

0 commit comments

Comments
 (0)