fix(npm-packages): handle scoped npm packages with format @package or…#114
Merged
koralowiec merged 5 commits intodevcontainers-extra:mainfrom Mar 31, 2025
TheOptimist:main
Merged
fix(npm-packages): handle scoped npm packages with format @package or…#114koralowiec merged 5 commits intodevcontainers-extra:mainfrom TheOptimist:main
koralowiec merged 5 commits intodevcontainers-extra:mainfrom
TheOptimist:main
Conversation
Contributor
Author
|
Apologies for the extra commits (dumb mistakes)...I've worked out how to enable the Actions on my own repository, and the tests are passing with these changes - https://github.com/TheOptimist/devcontainers-extra-features/pull/2 |
TheOptimist
commented
Mar 31, 2025
Member
|
FYI: The tests for a specific feature can be run locally with: just test <feature-name>https://github.com/devcontainers-extra/features/blob/main/CONTRIBUTING.md#using-just-commands |
Member
|
I think that
|
koralowiec
requested changes
Mar 31, 2025
Co-authored-by: Arek Kalandyk <36413794+koralowiec@users.noreply.github.com> Signed-off-by: George Cover <5285122+TheOptimist@users.noreply.github.com>
Co-authored-by: Arek Kalandyk <36413794+koralowiec@users.noreply.github.com> Signed-off-by: George Cover <5285122+TheOptimist@users.noreply.github.com>
koralowiec
reviewed
Mar 31, 2025
Member
koralowiec
left a comment
koralowiec
left a comment
There was a problem hiding this comment.
Thank you for your time in fixing this feature! Merging!
koralowiec
approved these changes
Mar 31, 2025
Member
|
The updated feature is available: https://github.com/devcontainers-extra/features/pkgs/container/features%2Fnpm-packages/385558298?tag=1.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #104 and building on the PR #110 (that seems stalled), this change supports the following package specification:
packagepackage@version@package@package@version