Skip to content

Commit 98082f9

Browse files
committed
fix: skip --platform and --output for platformTag builds
The devcontainer CLI rejects --platform for docker-compose-based devcontainers. When platformTag is set, the runner is already the correct native architecture, so --platform is unnecessary.
1 parent 3e2ff32 commit 98082f9

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

github-action/dist/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2253,10 +2253,10 @@ function runMain() {
22532253
workspaceFolder,
22542254
configFile,
22552255
imageName: fullImageNameArray,
2256-
platform,
2256+
platform: platformTag ? undefined : platform,
22572257
additionalCacheFroms: cacheFrom,
22582258
userDataFolder,
2259-
output: buildxOutput,
2259+
output: platformTag ? undefined : buildxOutput,
22602260
noCache,
22612261
cacheTo,
22622262
};

github-action/dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

github-action/src/main.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,10 +133,10 @@ export async function runMain(): Promise<void> {
133133
workspaceFolder,
134134
configFile,
135135
imageName: fullImageNameArray,
136-
platform,
136+
platform: platformTag ? undefined : platform,
137137
additionalCacheFroms: cacheFrom,
138138
userDataFolder,
139-
output: buildxOutput,
139+
output: platformTag ? undefined : buildxOutput,
140140
noCache,
141141
cacheTo,
142142
};

0 commit comments

Comments
 (0)