Skip to content

Commit 0ffb221

Browse files
committed
nits
1 parent 328335e commit 0ffb221

3 files changed

Lines changed: 12 additions & 8 deletions

File tree

src/spec-node/dockerCompose.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ export async function buildAndExtendDockerCompose(configWithRaw: SubstitutedConf
188188

189189
// determine whether we need to extend with features
190190
const version = parseVersion((await params.dockerComposeCLI()).version);
191-
const supportsAdditionalBuildContexts = params.cliVariant !== CLIVariant.Podman && params.cliVariant !== CLIVariant.Wslc && version && !isEarlierVersion(version, [2, 17, 0]);
191+
const supportsAdditionalBuildContexts = params.cliVariant === CLIVariant.Docker && version && !isEarlierVersion(version, [2, 17, 0]);
192192
const optionalBuildKitParams = supportsAdditionalBuildContexts ? params : { ...params, buildKitVersion: undefined };
193193
const extendImageBuildInfo = await getExtendImageBuildInfo(optionalBuildKitParams, configWithRaw, baseName, imageBuildInfo, composeService.user, additionalFeatures, canAddLabelsToContainer);
194194

src/spec-node/singleContainer.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -361,13 +361,13 @@ export async function spawnDevContainer(params: DockerResolverParameters, config
361361

362362
const featureArgs: string[] = [];
363363
// wslc does not support --init, --privileged, --cap-add, or --security-opt
364-
if (mergedConfig.init && params.cliVariant !== CLIVariant.Wslc) {
365-
featureArgs.push('--init');
366-
}
367-
if (mergedConfig.privileged && params.cliVariant !== CLIVariant.Wslc) {
368-
featureArgs.push('--privileged');
369-
}
370364
if (params.cliVariant !== CLIVariant.Wslc) {
365+
if (mergedConfig.init) {
366+
featureArgs.push('--init');
367+
}
368+
if (mergedConfig.privileged) {
369+
featureArgs.push('--privileged');
370+
}
371371
for (const cap of mergedConfig.capAdd || []) {
372372
featureArgs.push('--cap-add', cap);
373373
}

src/spec-shutdown/dockerUtils.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,11 @@ export async function removeContainer(params: DockerCLIParameters | PartialExecP
198198
});
199199
});
200200
}
201-
await Promise.race([removedSeenP || delay(1000), delay(1000)]);
201+
if (removedSeenP) {
202+
await Promise.race([removedSeenP, delay(1000)]);
203+
} else {
204+
await delay(1000);
205+
}
202206
}
203207
}
204208
} finally {

0 commit comments

Comments
 (0)