Skip to content

Commit feff09b

Browse files
Merge pull request #418 from devcontainers/samruddhikhandale/test-error-code
Fix -`devcontainer feature test` cmd should fail if Feature's sub-folder does not exist
2 parents 7cdffe8 + d85aaca commit feff09b

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

src/spec-node/featuresCLI/testCommandImpl.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { LaunchResult, staticExecParams, staticProvisionParams, testLibraryScrip
99
import { DockerResolverParameters } from '../utils';
1010
import { DevContainerConfig } from '../../spec-configuration/configuration';
1111
import { FeaturesTestCommandInput } from './test';
12-
import { cpDirectoryLocal } from '../../spec-utils/pfs';
12+
import { cpDirectoryLocal, rmLocal } from '../../spec-utils/pfs';
1313
import { nullLog } from '../../spec-utils/log';
1414

1515
const TEST_LIBRARY_SCRIPT_NAME = 'dev-container-features-test-lib';
@@ -310,6 +310,12 @@ async function generateDefaultProjectFromFeatures(
310310
for (const featureId of featuresToTest) {
311311
// Copy the feature source code to the temp folder
312312
const pathToFeatureSource = `${collectionsDirectory}/src/${featureId}`;
313+
314+
if (! await cliHost.isFolder(pathToFeatureSource)) {
315+
await rmLocal(tmpFolder, { recursive: true, force: true });
316+
fail(`Folder '${pathToFeatureSource}' does not exist for the '${featureId}' Feature.`);
317+
}
318+
313319
await cpDirectoryLocal(pathToFeatureSource, `${tmpFolder}/.devcontainer/${featureId}`);
314320
}
315321

0 commit comments

Comments
 (0)