Skip to content

Commit 465e5e1

Browse files
committed
Corrections based on review comments.
1 parent 9a72159 commit 465e5e1

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

src/desktop-lite/install.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -394,17 +394,16 @@ fi
394394
395395
# Spin up noVNC if installed and not running.
396396
if [ -d "/usr/local/novnc" ]; then
397-
NOVNC_VERSION_INSTALLED=\$(ls /usr/local/novnc | grep -oP 'noVNC-\K[0-9.]+' | head -n1)
398397
if [ "\$(ps -ef | grep /usr/local/novnc/noVNC*/utils/launch.sh | grep -v grep)" = "" ] && [ "\$(ps -ef | grep /usr/local/novnc/noVNC*/utils/novnc_proxy | grep -v grep)" = "" ]; then
399-
if version_gt "\$NOVNC_VERSION_INSTALLED" "1.2.0"; then
398+
if version_gt "${NOVNC_VERSION}" "1.2.0"; then
400399
keepRunningInBackground "noVNC" sudoIf "/usr/local/novnc/noVNC*/utils/novnc_proxy --listen ${NOVNC_PORT} --vnc localhost:${VNC_PORT}"
401400
log "noVNC started with novnc_proxy."
402401
else
403402
keepRunningInBackground "noVNC" sudoIf "/usr/local/novnc/noVNC*/utils/launch.sh --listen ${NOVNC_PORT} --vnc localhost:${VNC_PORT}"
404403
log "noVNC started with launch.sh."
405404
fi
406405
else
407-
log "noVNC is already running or not installed."
406+
log "noVNC is already."
408407
fi
409408
else
410409
log "noVNC is not installed."

0 commit comments

Comments
 (0)