[desktop-lite] - Adding support for noVnc latest version in the feature#1395
Merged
Merged
Conversation
AlvaroRausell
suggested changes
Jun 24, 2025
AlvaroRausell
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #1393
Description: This PR aims to solve #1393 by adding support for latest
noVncversion. All thenoVncversions post1.2.0are currently not working with thedesktop-litefeature due to unavailability oflaunch.shscript which is responsible for launching thenoVncclient. In these higher versions ofnoVncclient post1.2.0, the client is required to be started usingnovnc_proxyutility. Changes are done for adding that support & also ensured that support for the oldernoVncclients(<=1.2.0) remain as-is.Changlog: The following changes are done.
noVncclient versions higher that1.2.0devcontainer-feature.jsonto do version bump & pining thenoVncVersionproperty to the latest1.6.0version.Checklist: