[rust] - Introducing new options to install components#1404
Conversation
AlvaroRausell
left a comment
There was a problem hiding this comment.
I am not the biggest fan of having two flags for one action (installing custom components). I would prefer if we did the following:
create a components option, the default being rust-analyzer,rust-src,rustfmt,clippy` (what currently gets installed), but allowing it to be overridden. This will then allow a user to modify this list if required, without changing default behaviour.
So, as a summary:
- Remove
customComponents - Bump minor version.
Once that is done, I will go through the changes again to give a more detailed review
Hello @AlvaroRausell , Thank you for the review. I have done changes as per the comments provided. Would you kindly review the PR once again. |
AlvaroRausell
left a comment
There was a problem hiding this comment.
Good work, just one thing you missed
Ref: #1273
Description: This PR aims to solve #1273 to introduce new options
customComponentsandcomponentsto install rust components based on user inputChangelog: The following changes are included.
customComponentsandcomponents(comma separated value for the components to installed ) to install rust components based on user input.customComponentsandcomponentsto install rust components based on user input.Checklist: