Provide error response when failure occurs fetching Git tags#1414
Conversation
AlvaroRausell
left a comment
There was a problem hiding this comment.
Hello! Thanks for the contribution. Could you bump the patch version here please to 1.3.5?
… on newer curl releases
|
Hey @AlvaroRausell! I've updated the version and also changed my approach. It seems that |
|
Any updates on this @AlvaroRausell ? |
|
Thanks for the review @AlvaroRausell ! Do I need to take any further action to have this merged or will it be done at some stage by one of the admins? |
|
@Kaniska244 Free free to bump this up to Sam/Abdu, I don't remember exactly the context as to why I did not merge this, but should be fine (also, hi again!). |
|
Oh hey I completely forgot about this 😓 No problem thanks for taking care of this! |
For the past 2 days we have observed the git feature failing to install on random occasions with the following error:
From looking into the source of the git feature I was able to identify where this error is stemming from and found that the curl used to fetch git tags does not have proper error handling.
As such, I have updated the install.sh script to improve the error handling here so that we fail earlier and can see the actual response from the curl to understand what the issue is.
My hunch is that there could be some kind of rate limiting happening so I'm curious also if anyone else has been seeing this issue.