Skip to content

Provide error response when failure occurs fetching Git tags#1414

Merged
abdurriq merged 4 commits into
devcontainers:mainfrom
eimhin-rover:improve-git-version-error
Jan 23, 2026
Merged

Provide error response when failure occurs fetching Git tags#1414
abdurriq merged 4 commits into
devcontainers:mainfrom
eimhin-rover:improve-git-version-error

Conversation

@eimhin-rover

Copy link
Copy Markdown
Contributor

For the past 2 days we have observed the git feature failing to install on random occasions with the following error:

10.36 Invalid git version: latest
10.36 ERROR: Feature "Git (from source)" (ghcr.io/devcontainers/features/git) failed to install! Look at the documentation at ********/devcontainers/features/tree/main/src/git for help troubleshooting this error.

From looking into the source of the git feature I was able to identify where this error is stemming from and found that the curl used to fetch git tags does not have proper error handling.

As such, I have updated the install.sh script to improve the error handling here so that we fail earlier and can see the actual response from the curl to understand what the issue is.

My hunch is that there could be some kind of rate limiting happening so I'm curious also if anyone else has been seeing this issue.

@eimhin-rover eimhin-rover requested a review from a team as a code owner July 18, 2025 08:43

@AlvaroRausell AlvaroRausell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for the contribution. Could you bump the patch version here please to 1.3.5?

@eimhin-rover

eimhin-rover commented Jul 21, 2025

Copy link
Copy Markdown
Contributor Author

Hey @AlvaroRausell! I've updated the version and also changed my approach. It seems that --fail-with-body is not available on older versions of curl, so I've opted for a different approach to ensure backwards compatibility.

@eimhin-rover

Copy link
Copy Markdown
Contributor Author

Any updates on this @AlvaroRausell ?

@eimhin-rover

Copy link
Copy Markdown
Contributor Author

Thanks for the review @AlvaroRausell ! Do I need to take any further action to have this merged or will it be done at some stage by one of the admins?

@AlvaroRausell

AlvaroRausell commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

@Kaniska244 Free free to bump this up to Sam/Abdu, I don't remember exactly the context as to why I did not merge this, but should be fine (also, hi again!).
@eimhin-rover Sorry for the delay! I'm not at GitHub anymore, so I can't merge, sadly.

@Kaniska244 Kaniska244 requested a review from abdurriq January 23, 2026 12:44
@abdurriq abdurriq merged commit 7cc36aa into devcontainers:main Jan 23, 2026
12 checks passed
@eimhin-rover

Copy link
Copy Markdown
Contributor Author

Oh hey I completely forgot about this 😓 No problem thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants