Pin Oryx repository to working commit to fix build failure#1539
Pin Oryx repository to working commit to fix build failure#1539
Conversation
Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
|
@copilot Why wasn't it fixed on the main branch, and can we not fix instead of pinning to a commit? |
The issue is in the upstream microsoft/Oryx repository, not in devcontainers/features. The breaking commit (21c559437d69cb43fd9b34f01f68c43ea4bce318) added a I checked the current Oryx main branch - the bug is still present (MemorySourceRepo still doesn't implement GetFileSize). The proper fix would be to submit a PR to microsoft/Oryx to add the missing implementation. Pinning to a working commit is the appropriate short-term workaround since:
The pin should be removed once the upstream issue is resolved, which is why I documented it in NOTES.md. |
The Oryx feature test fails on ubuntu:focal because upstream commit
21c559437d69cb43fd9b34f01f68c43ea4bce318(2026-01-13) addedISourceRepo.GetFileSize()without updating theMemorySourceRepotest mock, breaking compilation.Changes
689fdef61a38802f1e1deda40be5933cc75e3631- Last known working version before breaking change--depth=1flag to enable checkout of specific commitgit checkoutafter clone to pin versioncdcommandsThe pin should be removed once upstream resolves the compilation error.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.