fix: update environment variable access to bracket notation and enhance TypeScript configuration with stricter checks

Author: developer-sumit

index.ts

@@ -9,7 +9,7 @@ import { installJDK, installAndroidStudio } from "./src/install-scripts";
 /** Main setup function */
 async function setup() {
   // Check for config from environment variable (for testing/automation)
-  const envConfig = process.env.RN_LAB_CONFIG;
+  const envConfig = process.env["RN_LAB_CONFIG"];
   let prompt;
 
   if (envConfig) {

src/helpers/get-pkg-manager.ts

@@ -7,7 +7,7 @@ export type PackageManager = "npm" | "yarn" | "bun";
  * If no specific package manager is detected, defaults to "npm".
  */
 export default function getPkgManager(): PackageManager {
-  const userAgent = process.env.npm_config_user_agent || "";
+  const userAgent = process.env["npm_config_user_agent"] || "";
 
   if (userAgent.startsWith("npm")) {
     return "npm";

src/install-scripts.ts

@@ -19,19 +19,21 @@ export async function installChocolatey() {
       return;
     }
     spinner.info(
-      colors.yellow("Running Chocolatey installation as non-admin...")
+      colors.yellow("Running Chocolatey installation as non-admin..."),
     );
     const scriptPath = getScriptPath("installChocolately.ps1");
     // Execute the PowerShell script for non-admin installation
     execSync(`powershell.exe -ExecutionPolicy Bypass -File "${scriptPath}"`, {
       stdio: "inherit",
     });
     spinner.succeed(
-      colors.green("Chocolatey installed successfully (non-admin).")
+      colors.green("Chocolatey installed successfully (non-admin)."),
     );
     // Add Chocolatey to the current session's PATH
-    const chocoPath = `${process.env.ProgramData}\\chocoportable\\bin`;
-    process.env.PATH = `${process.env.PATH};${chocoPath}`;
+    const programData = process.env["ProgramData"] || "C:\\ProgramData";
+    const chocoPath = `${programData}\\chocoportable\\bin`;
+    const currentPath = process.env["PATH"] || "";
+    process.env["PATH"] = `${currentPath};${chocoPath}`;
   } catch (error) {
     spinner.fail(colors.red("Failed to install Chocolatey."));
     console.error(error);
@@ -68,11 +70,11 @@ export async function installJDK() {
           stdio: "inherit",
         });
         spinner.succeed(
-          colors.green("JAVA_HOME environment variable set successfully.")
+          colors.green("JAVA_HOME environment variable set successfully."),
         );
       } catch (error) {
         spinner.fail(
-          colors.red("Failed to set JAVA_HOME environment variable.")
+          colors.red("Failed to set JAVA_HOME environment variable."),
         );
         throw error;
       }
@@ -102,18 +104,18 @@ export async function installJDK() {
         });
         execSync("source ~/.bashrc", { stdio: "inherit" });
         spinner.succeed(
-          colors.green("JAVA_HOME environment variable set successfully.")
+          colors.green("JAVA_HOME environment variable set successfully."),
         );
       } catch (error) {
         spinner.fail(
-          colors.red("Failed to set JAVA_HOME environment variable.")
+          colors.red("Failed to set JAVA_HOME environment variable."),
         );
         throw error;
       }
     }
   } else {
     spinner.fail(
-      colors.red("Please install OpenJDK manually on this operating system.")
+      colors.red("Please install OpenJDK manually on this operating system."),
     );
   }
 }
@@ -129,11 +131,11 @@ export async function installAndroidStudio() {
     await installChocolatey();
   }
   const androidStudioPath = path.join(
-    process.env.ProgramFiles || "C:\\Program Files",
+    process.env["ProgramFiles"] || "C:\\Program Files",
     "Android",
     "Android Studio",
     "bin",
-    "studio.exe"
+    "studio.exe",
   );
 
   if (process.platform === "win32") {
@@ -163,14 +165,14 @@ export async function installAndroidStudio() {
 
     // Set ANDROID_HOME environment variable
     const androidHomePath = path.join(
-      process.env.ProgramFiles || "C:\\Program Files",
+      process.env["ProgramFiles"] || "C:\\Program Files",
       "Android",
-      "Sdk"
+      "Sdk",
     );
 
     if (!fs.existsSync(androidHomePath)) {
       pathSpinner.fail(
-        colors.red("Android SDK not found. Please install Android Studio.")
+        colors.red("Android SDK not found. Please install Android Studio."),
       );
       return;
     }
@@ -185,17 +187,17 @@ export async function installAndroidStudio() {
 
       execSync(
         `setx PATH "%PATH%;${androidHomePath}\\tools;${androidHomePath}\\platform-tools" /M`,
-        { stdio: "inherit" }
+        { stdio: "inherit" },
       );
 
       pathSpinner.succeed(
-        colors.green("Android Studio added to PATH successfully.")
+        colors.green("Android Studio added to PATH successfully."),
       );
     } catch (error) {
       pathSpinner.fail(
         colors.red(
-          "Failed to set ANDROID_HOME and ANDROID_SDK_ROOT environment variables."
-        )
+          "Failed to set ANDROID_HOME and ANDROID_SDK_ROOT environment variables.",
+        ),
       );
       console.error(error);
       throw error;
@@ -219,14 +221,14 @@ export async function installAndroidStudio() {
 
     // Set ANDROID_HOME environment variable
     const androidHomePath = path.join(
-      process.env.HOME || "/home/user",
+      process.env["HOME"] || "/home/user",
       "Android",
-      "Sdk"
+      "Sdk",
     );
 
     if (!fs.existsSync(androidHomePath)) {
       pathSpinner.fail(
-        colors.red("Android SDK not found. Please install Android Studio.")
+        colors.red("Android SDK not found. Please install Android Studio."),
       );
       return;
     }
@@ -239,33 +241,33 @@ export async function installAndroidStudio() {
         `echo "export ANDROID_SDK_ROOT=${androidHomePath}" >> ~/.bashrc`,
         {
           stdio: "inherit",
-        }
+        },
       );
       execSync(
         `echo "export PATH=$PATH:${androidHomePath}/tools:${androidHomePath}/platform-tools" >> ~/.bashrc`,
         {
           stdio: "inherit",
-        }
+        },
       );
       execSync("source ~/.bashrc", { stdio: "inherit" });
 
       pathSpinner.succeed(
-        colors.green("Android Studio added to PATH successfully.")
+        colors.green("Android Studio added to PATH successfully."),
       );
     } catch (error) {
       pathSpinner.fail(
         colors.red(
-          "Failed to set ANDROID_HOME and ANDROID_SDK_ROOT environment variables."
-        )
+          "Failed to set ANDROID_HOME and ANDROID_SDK_ROOT environment variables.",
+        ),
       );
       console.error(error);
       throw error;
     }
   } else {
     spinner.fail(
       colors.red(
-        "Please install Android Studio manually on this operating system."
-      )
+        "Please install Android Studio manually on this operating system.",
+      ),
     );
   }
 }

src/prompts.ts

@@ -16,7 +16,7 @@ import { fetchReactNativeVersions } from "./helpers/fetch-rn-versions";
 import { PackageManager } from "./helpers/get-pkg-manager";
 import { TemplateType, EnvPackages } from "./types";
 
-const { blue, red, green, yellow } = colors;
+const { blue, red, green } = colors;
 
 function handleCancel(value: unknown) {
   if (isCancel(value)) {

src/react-native-lab.ts

@@ -2,15 +2,7 @@
 import colors from "picocolors";
 import { execSync } from "node:child_process";
 import { basename, dirname, join, resolve } from "node:path";
-import {
-  copyFileSync,
-  existsSync,
-  mkdirSync,
-  readFileSync,
-  writeFileSync,
-  readdirSync,
-  renameSync,
-} from "node:fs";
+import { copyFileSync, existsSync, mkdirSync, readdirSync } from "node:fs";
 import { rmSync } from "node:fs";
 
 import { getTemplateFile, installTemplate } from "./template";
@@ -22,11 +14,7 @@ import { PackageManager } from "./helpers/get-pkg-manager";
 import { EnvPackages, TemplateType } from "./types";
 import { setupCI as initCI } from "./helpers/ci";
 
-function fixAndroidPackageStructure(
-  root: string,
-  packageName: string,
-  appName: string,
-) {
+function fixAndroidPackageStructure(root: string, packageName: string) {
   const androidJavaPath = join(root, "android", "app", "src", "main", "java");
 
   if (!existsSync(androidJavaPath)) {
@@ -171,7 +159,7 @@ export default async function createReactNative({
 
   // Fix Android package structure if a custom package name was provided
   if (packageName) {
-    fixAndroidPackageStructure(root, packageName, appName);
+    fixAndroidPackageStructure(root, packageName);
   }
 
   // Copy `.gitignore` if the application did not provide one

src/template.ts

@@ -2,7 +2,6 @@ import os from "os";
 import fs from "fs/promises";
 import { fileURLToPath } from "url";
 import path, { dirname } from "path";
-import { execSync } from "child_process";
 import picocolors from "picocolors";
 import { copyFiles } from "./helpers/copy";
 import HookTemplates from "./templates/snippets/hooks";
@@ -32,7 +31,6 @@ export const SRC_DIR_NAMES = ["assets", "screens", "components", "helpers"];
 
 export const installTemplate = async ({
   appName,
-  packageName,
   root,
   packageManager,
   envEnabled,
@@ -43,7 +41,6 @@ export const installTemplate = async ({
   template,
   srcDir,
   nativeWind,
-  skipInstall,
 }: InstallTemplateArgs) => {
   console.log(bold(`Using ${packageManager}.`));
   const isReactNativeDotEnv =
@@ -119,7 +116,6 @@ export const installTemplate = async ({
   const packageJson = await updatePackageJson(
     root,
     appName,
-    packageName,
     isReactNativeDotEnv,
     isReactNativeConfig,
     nativeWind,
@@ -240,7 +236,6 @@ function generateTsConfig(srcDir: boolean, template: string) {
 async function updatePackageJson(
   root: string,
   appName: string,
-  packageName: string | undefined,
   isReactNativeDotEnv: boolean,
   isReactNativeConfig: boolean,
   nativeWind: boolean,

tsconfig.json

@@ -19,7 +19,16 @@
     // Skips type checking of declaration files (can speed up compilation)
     "skipLibCheck": true,
     // Ensures that file names are case-sensitive
-    "forceConsistentCasingInFileNames": true
+    "forceConsistentCasingInFileNames": true,
+    // Report unused locals and parameters
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    // Prevent fallthrough in switch statements
+    "noFallthroughCasesInSwitch": true,
+    // Require explicit override keyword when overriding
+    "noImplicitOverride": true,
+    // Ensure index access is intentional
+    "noPropertyAccessFromIndexSignature": true
   },
   "exclude": ["node_modules", "dist", "./src/templates"]
 }