fix: repair platform build issues and ci

Author: developer239

.github/workflows/build.yml

@@ -0,0 +1,120 @@
+name: CI
+
+on:
+  push:
+    branches: [ master ]
+    paths:
+      - 'include/**'
+      - 'src/**'
+      - 'tests/**'
+      - 'examples/**'
+      - 'cmake/**'
+      - 'externals/**'
+      - 'CMakeLists.txt'
+      - '.github/workflows/**'
+  pull_request:
+    branches: [ master ]
+    paths:
+      - 'include/**'
+      - 'src/**'
+      - 'tests/**'
+      - 'examples/**'
+      - 'cmake/**'
+      - 'externals/**'
+      - 'CMakeLists.txt'
+      - '.github/workflows/**'
+
+permissions:
+  contents: read
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  build-test:
+    name: ${{ matrix.name }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - name: Linux (GCC 14)
+            os: ubuntu-latest
+            examples: 'ON'
+            cmake_args: ''
+          - name: macOS (Apple Clang)
+            os: macos-15
+            # The examples use std::println, and Apple Clang's libc++ does not
+            # ship <print> yet. The library and unit tests use std::format and
+            # std::expected, which this toolchain has.
+            examples: 'OFF'
+            cmake_args: ''
+          - name: Windows (MSVC)
+            os: windows-latest
+            examples: 'ON'
+            cmake_args: '-A x64'
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: recursive
+
+      - name: Install Linux dependencies
+        if: runner.os == 'Linux'
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y g++-14 libx11-dev libxtst-dev libxrandr-dev
+          echo "CC=gcc-14" >> "$GITHUB_ENV"
+          echo "CXX=g++-14" >> "$GITHUB_ENV"
+
+      - name: Print CMake version
+        run: cmake --version
+
+      - name: Configure
+        run: >
+          cmake -S . -B build ${{ matrix.cmake_args }}
+          -DCMAKE_BUILD_TYPE=Release
+          -DROBOT_BUILD_TESTS=ON
+          -DROBOT_BUILD_EXAMPLES=${{ matrix.examples }}
+
+      - name: Build
+        run: cmake --build build --config Release --parallel
+
+      - name: Unit tests
+        run: ctest --test-dir build -C Release --output-on-failure
+
+  sanitizers:
+    name: Sanitizers (ASan + UBSan)
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: recursive
+
+      - name: Install dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y g++-14 libx11-dev libxtst-dev libxrandr-dev
+
+      - name: Configure
+        env:
+          CC: gcc-14
+          CXX: g++-14
+        run: >
+          cmake -S . -B build
+          -DCMAKE_BUILD_TYPE=RelWithDebInfo
+          -DROBOT_BUILD_TESTS=ON
+          -DROBOT_BUILD_EXAMPLES=OFF
+          -DCMAKE_CXX_FLAGS="-fsanitize=address,undefined -fno-sanitize-recover=all"
+          -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=address,undefined"
+
+      - name: Build
+        run: cmake --build build --parallel
+
+      - name: Unit tests
+        env:
+          UBSAN_OPTIONS: print_stacktrace=1:halt_on_error=1
+          ASAN_OPTIONS: detect_leaks=1
+        run: ctest --test-dir build --output-on-failure

.github/workflows/ci.yml

@@ -23,8 +23,6 @@ else()
 endif()
 
 option(ROBOT_BUILD_TESTS "Build robot-cpp tests" ${ROBOT_IS_TOPLEVEL})
-option(ROBOT_BUILD_INTERACTIVE_TESTS
-    "Build the SDL-driven interactive injection tests (needs a live display)" OFF)
 option(ROBOT_BUILD_EXAMPLES "Build robot-cpp examples" ${ROBOT_IS_TOPLEVEL})
 option(ROBOT_WERROR "Treat warnings as errors" OFF)
 option(ROBOT_LINUX_ENABLE_UINPUT "Build the Linux uinput backend" ON)
@@ -88,7 +86,7 @@ elseif(WIN32)
         src/platform/windows/WinScreenBackend.cpp
         src/platform/windows/WinEventTapBackend.cpp
     )
-elseif(UNIX)
+elseif(UNIX AND NOT APPLE)
     set(ROBOT_PLATFORM_SOURCES
         src/platform/linux/LinuxBackendFactory.cpp
         src/platform/linux/LinuxPlatformBackend.cpp
@@ -148,8 +146,14 @@ elseif(WIN32)
     target_link_libraries(robot PRIVATE user32 gdi32)
     target_compile_definitions(robot PRIVATE
         WIN32_LEAN_AND_MEAN NOMINMAX UNICODE _UNICODE)
-elseif(UNIX)
+elseif(UNIX AND NOT APPLE)
     find_package(X11 REQUIRED)
+    if(NOT TARGET X11::Xtst)
+        message(FATAL_ERROR "robot-cpp: XTest development files are required")
+    endif()
+    if(NOT TARGET X11::Xrandr)
+        message(FATAL_ERROR "robot-cpp: XRandR development files are required")
+    endif()
     # X11 headers are used only in platform .cpp files -> PRIVATE. XTest and
     # Xrandr components ship with X11; XRecord lives in libXtst as well.
     target_link_libraries(robot PRIVATE
@@ -199,6 +203,12 @@ file(WRITE "${CMAKE_CURRENT_BINARY_DIR}/robotConfig.cmake"
 "include(CMakeFindDependencyMacro)\n\
 if(UNIX AND NOT APPLE)\n\
   find_dependency(X11)\n\
+  if(NOT TARGET X11::Xtst)\n\
+    message(FATAL_ERROR \"robot-cpp: XTest development files are required\")\n\
+  endif()\n\
+  if(NOT TARGET X11::Xrandr)\n\
+    message(FATAL_ERROR \"robot-cpp: XRandR development files are required\")\n\
+  endif()\n\
 endif()\n\
 include(\"\${CMAKE_CURRENT_LIST_DIR}/robotTargets.cmake\")\n")
 

.github/workflows/test-macos.yml

@@ -10,7 +10,7 @@ namespace {
 
 using robot::Key;
 
-constexpr std::array<std::pair<Key, std::uint16_t>, 100> kTable{{
+constexpr auto kTable = std::to_array<std::pair<Key, std::uint16_t>>({
     {Key::A, KEY_A}, {Key::B, KEY_B}, {Key::C, KEY_C}, {Key::D, KEY_D},
     {Key::E, KEY_E}, {Key::F, KEY_F}, {Key::G, KEY_G}, {Key::H, KEY_H},
     {Key::I, KEY_I}, {Key::J, KEY_J}, {Key::K, KEY_K}, {Key::L, KEY_L},
@@ -52,7 +52,7 @@ constexpr std::array<std::pair<Key, std::uint16_t>, 100> kTable{{
     {Key::LeftAlt, KEY_LEFTALT}, {Key::LeftMeta, KEY_LEFTMETA},
     {Key::RightControl, KEY_RIGHTCTRL}, {Key::RightShift, KEY_RIGHTSHIFT},
     {Key::RightAlt, KEY_RIGHTALT}, {Key::RightMeta, KEY_RIGHTMETA},
-}};
+});
 
 }  // namespace
 
@@ -70,4 +70,4 @@ std::optional<std::uint16_t> keyToEvdev(const Key key) {
   return it->second;
 }
 
-}  // namespace robot::linux_evdev
+}  // namespace robot::linux_evdev