mac support added#9
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's README to accurately communicate the current state of macOS support, indicating that it is now fully compatible. This ensures users have up-to-date information regarding platform availability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to indicate that macOS is now supported. However, a critical bug has been identified in src/Install/LibraryInstaller.php where the logic for determining the library file name for macOS is incorrect, potentially preventing macOS support from functioning as intended. It is also suggested that this installer script be removed if it is obsolete to improve maintainability.
| - **Linux**: ☑️ | ||
| - **Windows**: ☑️ | ||
| - **macOS**: Coming soon. | ||
| - **macOS**: ☑️ |
There was a problem hiding this comment.
This change updates the documentation to reflect macOS support. However, src/Install/LibraryInstaller.php contains logic that appears to be incorrect for macOS and could cause issues.
// src/Install/LibraryInstaller.php:47
$libFile = PHP_OS_FAMILY === 'Windows' ? 'tcl86t.dll' : 'libtcl.so';For macOS (PHP_OS_FAMILY === 'Darwin'), this would incorrectly look for libtcl.so instead of a .dylib file.
If this installer script is in use, this is a critical bug that needs to be fixed for macOS support to work.
If this script is obsolete (as the /** Garbage class */ docblock at line 7 might imply), it should be removed to prevent confusion and future maintenance issues. Leaving incorrect, dead code in the repository is a maintainability concern.
No description provided.