add failing tests

Author: hrodmn

lib/stac-loader/runtime/tests/conftest.py

@@ -120,6 +120,30 @@ def check_item_exists(database_url, collection_id, item_id):
         return result[0][0] > 0
 
 
+def get_item(database_url, collection_id, item_id):
+    """
+    Get the item with the given ID in the specified collection.
+
+    Args:
+        database_url: Connection string for the database
+        collection_id: The collection ID to check
+        item_id: The item ID to check
+
+    Returns:
+        dict: STAC item dict
+    """
+    with PgstacDB(dsn=database_url) as db:
+        # Direct SQL query to check if the item exists
+        query = """
+        SELECT id, collection, content
+        FROM pgstac.items
+        WHERE collection = %s AND id = %s
+        """
+
+        result = list(db.query(query, (collection_id, item_id)))[0]
+        return {"id": result[0], "collection": result[1], "content": result[2]}
+
+
 def get_all_collection_items(database_url, collection_id):
     """
     Get all items in a collection from the database.

lib/stac-loader/runtime/tests/test_stac_loader_handler.py

@@ -12,6 +12,7 @@
     count_collections,
     get_all_collection_items,
     get_collection,
+    get_item,
 )
 from pypgstac.db import PgstacDB
 from stac_loader.handler import get_pgstac_dsn, handler
@@ -202,6 +203,52 @@ def test_handler_with_multiple_items(mock_aws_context, mock_pgstac_dsn, database
     )
 
 
+def test_handler_with_identical_ids(mock_aws_context, mock_pgstac_dsn, database_url):
+    """Test handler with multiple valid STAC items"""
+    collection_id = TEST_COLLECTION_IDS[0]
+
+    # Create multiple valid items with the same id
+    item_id = "new-item"
+    items = [
+        create_valid_stac_item(item_id=item_id, collection_id=collection_id)
+        for _ in range(2)
+    ]
+
+    items[0]["properties"]["priority"] = 2
+    items[-1]["properties"]["priority"] = 1
+
+    # Create event with multiple records
+    event = {
+        "Records": [
+            create_sqs_record(item, message_id=f"test-message-{i}")
+            for i, item in enumerate(items)
+        ]
+    }
+
+    # Get initial count of items in the collection
+    initial_count = count_collection_items(database_url, collection_id)
+
+    # Call handler
+    result = handler(event, mock_aws_context)
+
+    # All should succeed
+    assert result is None
+
+    # Verify the item was added
+    assert check_item_exists(database_url, collection_id, item_id), (
+        f"Item {item_id} was not found in the database"
+    )
+
+    # Verify the count increased by the expected amount
+    new_count = count_collection_items(database_url, collection_id)
+    assert new_count == initial_count + 1, (
+        f"Expected {initial_count + 1} items, but found {new_count}"
+    )
+
+    ingested_item = get_item(database_url, collection_id, item_id)
+    assert ingested_item["content"]["properties"]["priority"] == 1
+
+
 def test_handler_with_mixed_items(mock_aws_context, mock_pgstac_dsn, database_url):
     """Test handler with a mix of valid and invalid items"""
     collection_id = TEST_COLLECTION_IDS[0]
@@ -735,6 +782,52 @@ def test_handler_with_multiple_collections(
     )
 
 
+def test_handler_with_identical_collections(
+    mock_aws_context, mock_pgstac_dsn, database_url
+):
+    """Test handler with multiple collections with the same ID"""
+    collection_id = "new-collection"
+    collections = [
+        create_valid_stac_collection(collection_id=collection_id) for _ in range(2)
+    ]
+
+    collections[0]["priority"] = 2
+    collections[-1]["priority"] = 1
+
+    # Create event with multiple collection records
+    event = {
+        "Records": [
+            create_sqs_record(collection, message_id=f"test-collection-message-{i}")
+            for i, collection in enumerate(collections)
+        ]
+    }
+
+    # Get initial count of collections
+    initial_count = count_collections(database_url)
+
+    # Call handler
+    result = handler(event, mock_aws_context)
+
+    # All should succeed
+    assert result is None
+
+    # Verify the collection was added
+    assert check_collection_exists(database_url, collection_id), (
+        f"Collection {collection_id} was not found in the database"
+    )
+
+    # Verify the count increased by the expected amount
+    new_count = count_collections(database_url)
+    assert new_count == initial_count + 1, (
+        f"Expected {initial_count + 1} collections, but found {new_count}"
+    )
+
+    # Make sure the last entry for the collection was ingested
+    ingested_collection = get_collection(database_url, collection_id)
+
+    assert ingested_collection["content"]["priority"] == 1
+
+
 def test_handler_with_invalid_collection(mock_aws_context, mock_pgstac_dsn):
     """Test handler with an invalid STAC collection (missing required fields)"""
     # Create an invalid STAC collection (missing extent)