feat: Allow S3 HTTP URLs without region (#590)

kylebarron · web-flow · commit aec2ed560e72 · 2025-12-16T16:56:22.000Z
diff --git a/pyo3-object_store/src/aws/store.rs b/pyo3-object_store/src/aws/store.rs
@@ -394,6 +394,10 @@ fn parse_url(
                     config.insert_if_not_exists(AmazonS3ConfigKey::Bucket, bucket);
                 }
             }
+            Some((bucket, "s3", "amazonaws", "com")) => {
+                config.insert_if_not_exists(AmazonS3ConfigKey::Bucket, bucket);
+                config.insert_if_not_exists(AmazonS3ConfigKey::VirtualHostedStyleRequest, "true");
+            }
             Some((bucket, "s3", region, "amazonaws.com")) => {
                 config.insert_if_not_exists(AmazonS3ConfigKey::Bucket, bucket);
                 config.insert_if_not_exists(AmazonS3ConfigKey::Region, region);

Original file line number	Diff line number	Diff line change
`@@ -394,6 +394,10 @@ fn parse_url(`
`394`	`394`	`config.insert_if_not_exists(AmazonS3ConfigKey::Bucket, bucket);`
`395`	`395`	`}`
`396`	`396`	`}`
	`397`	`+ Some((bucket, "s3", "amazonaws", "com")) => {`
	`398`	`+ config.insert_if_not_exists(AmazonS3ConfigKey::Bucket, bucket);`
	`399`	`+ config.insert_if_not_exists(AmazonS3ConfigKey::VirtualHostedStyleRequest, "true");`
	`400`	`+ }`
`397`	`401`	`Some((bucket, "s3", region, "amazonaws.com")) => {`
`398`	`402`	`config.insert_if_not_exists(AmazonS3ConfigKey::Bucket, bucket);`
`399`	`403`	`config.insert_if_not_exists(AmazonS3ConfigKey::Region, region);`