fix: Raise error when passing credential provider with http url (#465)

Author: kylebarron

obstore/python/obstore/store.py

@@ -797,7 +797,7 @@ def from_url(  # noqa: C901
             **kwargs,
         )
     if scheme == "http":
-        if config or kwargs:
+        if config or kwargs or credential_provider:
             msg = "HTTPStore does not accept any configuration"
             raise BaseError(msg)
 
@@ -813,6 +813,9 @@ def from_url(  # noqa: C901
             automatic_cleanup = kwargs.pop("automatic_cleanup")
         if "mkdir" in kwargs:
             mkdir = kwargs.pop("mkdir")
+        if credential_provider:
+            msg = "LocalStore does not accept a credential provider"
+            raise BaseError(msg)
 
         return LocalStore.from_url(
             url,

tests/store/test_from_url.py

@@ -1,10 +1,16 @@
+from __future__ import annotations
+
 from pathlib import Path
+from typing import TYPE_CHECKING
 
 import pytest
 
 from obstore.exceptions import BaseError, UnknownConfigurationKeyError
 from obstore.store import from_url
 
+if TYPE_CHECKING:
+    from obstore.store import S3Credential
+
 
 def test_local():
     cwd = Path().absolute()
@@ -55,3 +61,11 @@ def test_http():
 
     with pytest.raises(BaseError):
         from_url(url, bucket="test")
+
+
+def test_credential_provider_to_http_store_raises():
+    def s3_credential_provider() -> S3Credential:
+        return {"access_key_id": "", "secret_access_key": "", "expires_at": None}
+
+    with pytest.raises(BaseError):
+        from_url("http://mydomain/path", credential_provider=s3_credential_provider)