fix: Remove TypeVar constraints on arro3-core to fix list typing when arro3-core not installed#578
Merged
Merged
Conversation
… arro3-core not installed
Member
Author
|
@ion-elgreco can you test out this branch to see if it works for you as well? |
|
@kylebarron definitely, I'll test it out tomorrow! |
|
@kylebarron great, this indeed works! So when arro3-core is not installed and return_arrow=False, you properly see Sequence[objectMeta]. If you set return_arrow=True it gives unknown, but that makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #572. We'll see if this passes CI for type checking against obspec.