feat: Allow S3 HTTP URLs without region#590
Merged
Merged
Conversation
This was referenced Oct 29, 2025
Merged
Member
Author
|
Ref similar upstream PR in apache/arrow-rs-object-store#523 (we vendor this piece of code so that we can apply URL parsing onto the config instead of onto the builder) |
Member
Author
|
The upstream PR apache/arrow-rs-object-store#523 was merged, so we can merge this as well to stay consistent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #589
This doesn't infer a region from the URL by default. I think
S3Storedefaults tous-east-1if no other information has been passed. So for any URLs in other regions, the user will have to specify the correct region.cc @vincentsarago
We should make this same PR to upstream as well