Skip to content

Commit 4df00eb

Browse files
committed
ci: remove helm chart from release please automation
1 parent 02534bd commit 4df00eb

3 files changed

Lines changed: 5 additions & 29 deletions

File tree

.release-please-manifest.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
{
2-
".": "2.0.2",
3-
"deployment/k8s/charts": "2.1.2"
2+
".": "2.0.2"
43
}

RELEASING.md

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -11,24 +11,9 @@ Releases are automated via [release-please](https://github.com/googleapis/releas
1111
- Updates `CHANGES.md` with the changelog for the new version
1212
3. When that PR is merged, release-please creates a GitHub release tagged `X.Y.Z`, which triggers the PyPI publish workflow.
1313

14-
## Helm chart releases
14+
## Helm chart version
1515

16-
The Helm chart (`deployment/k8s/charts/`) is versioned independently from the Python package. release-please opens a separate helm release PR when commits touch files under `deployment/k8s/charts/`. That PR bumps `version:` in `Chart.yaml` and updates `deployment/k8s/charts/CHANGELOG.md`. The resulting GitHub release is tagged `helm-vX.Y.Z`.
17-
18-
**Commit messages matter for chart releases.** A chart version bump only happens when a commit both:
19-
- touches at least one file under `deployment/k8s/charts/`, **and**
20-
- uses a bump-triggering type (`fix:`, `feat:`, or a breaking change)
21-
22-
`chore:`, `ci:`, `docs:`, and other non-bumping types that touch chart files are valid conventional commits but will **not** produce a chart release. Use them for housekeeping that doesn't warrant a version bump (e.g. updating CI config, fixing a comment).
23-
24-
Examples:
25-
26-
```
27-
fix(helm): correct resource limit defaults → patch bump
28-
feat(helm): add support for extra environment vars → minor bump
29-
feat(helm)!: rename required value X to Y → major bump
30-
chore(helm): update maintainer list → no bump
31-
```
16+
The Helm chart `version:` in `deployment/k8s/charts/Chart.yaml` is **not** managed by release-please. The chart version is bumped manually when chart structure changes (templates, values, dependencies). The `appVersion` field (the titiler app version the chart deploys) is still updated automatically alongside every Python release, and as part of this process, the chart version can be manually updated by bumping the version in a simple commit in the release please PR.
3217

3318
## Commit message convention
3419

@@ -40,6 +25,6 @@ Version bumps follow [semantic versioning](https://semver.org/) based on commit
4025
| `feat:` | minor |
4126
| `feat!:` or `BREAKING CHANGE:` footer | major |
4227

43-
## No manual steps required
28+
## (Almost) No manual steps required
4429

45-
All version files are updated automatically. Do not manually edit version strings in `pyproject.toml`, `Chart.yaml`, or `__init__.py` files — release-please owns those.
30+
All version files are updated automatically. Do not manually edit version strings in `pyproject.toml`, `Chart.yaml` (`appVersion`), or `__init__.py` files — release-please owns those. The `version:` field in `Chart.yaml` is the only exception: bump it manually when chart structure changes warrant a new chart release.

release-please-config.json

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,6 @@
4141
{ "type": "generic", "path": "deployment/aws/lambda/Dockerfile" },
4242
{ "type": "generic", "path": "deployment/k8s/charts/Chart.yaml" }
4343
]
44-
},
45-
"deployment/k8s/charts": {
46-
"release-type": "helm",
47-
"package-name": "titiler-helm",
48-
"changelog-path": "deployment/k8s/charts/CHANGELOG.md",
49-
"include-component-in-tag": true,
50-
"include-v-in-tag": false,
51-
"component": "helm"
5244
}
5345
}
5446
}

0 commit comments

Comments
 (0)