AWS, Core, Flink, Parquet: Remove deprecations for 1.10.0 (apache#12909)

Author: manuzhang

.palantir/revapi.yml

@@ -1253,6 +1253,103 @@ acceptedBreaks:
       old: "method void org.apache.iceberg.data.parquet.BaseParquetWriter<T>::<init>()"
       new: "method void org.apache.iceberg.data.parquet.BaseParquetWriter<T>::<init>()"
       justification: "Changing deprecated code"
+  "1.9.0":
+    org.apache.iceberg:iceberg-core:
+    - code: "java.class.removed"
+      old: "class org.apache.iceberg.MetadataUpdate.EnableRowLineage"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.class.removed"
+      old: "class org.apache.iceberg.MetadataUpdate.RemoveSnapshot"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.class.removed"
+      old: "class org.apache.iceberg.actions.SizeBasedDataRewriter"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.class.removed"
+      old: "class org.apache.iceberg.actions.SizeBasedFileRewriter<T extends org.apache.iceberg.ContentScanTask<F\
+        \ extends org.apache.iceberg.ContentFile<F>>, F>"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.class.removed"
+      old: "class org.apache.iceberg.actions.SizeBasedPositionDeletesRewriter"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.class.removed"
+      old: "interface org.apache.iceberg.actions.FileRewriter<T extends org.apache.iceberg.ContentScanTask<F\
+        \ extends org.apache.iceberg.ContentFile<F>>, F>"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.field.removedWithConstant"
+      old: "field org.apache.iceberg.TableProperties.ROW_LINEAGE"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method boolean org.apache.iceberg.TableMetadata::rowLineageEnabled()"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method int org.apache.iceberg.actions.RewriteFileGroup::numFiles()"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method int org.apache.iceberg.actions.RewritePositionDeletesGroup::numRewrittenDeleteFiles()"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method java.util.List<org.apache.iceberg.FileScanTask> org.apache.iceberg.actions.RewriteFileGroup::fileScans()"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method java.util.List<org.apache.iceberg.PositionDeletesScanTask> org.apache.iceberg.actions.RewritePositionDeletesGroup::tasks()"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method long org.apache.iceberg.PartitionStats::totalRecordCount()"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method long org.apache.iceberg.actions.RewriteFileGroup::sizeInBytes()"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method long org.apache.iceberg.actions.RewritePositionDeletesGroup::rewrittenBytes()"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method org.apache.iceberg.TableMetadata.Builder org.apache.iceberg.TableMetadata.Builder::enableRowLineage()"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method void org.apache.iceberg.GenericManifestFile::<init>(java.lang.String,\
+        \ long, int, org.apache.iceberg.ManifestContent, long, long, java.lang.Long,\
+        \ int, long, int, long, int, long, java.util.List<org.apache.iceberg.ManifestFile.PartitionFieldSummary>,\
+        \ java.nio.ByteBuffer)"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method void org.apache.iceberg.actions.RewriteFileGroup::<init>(org.apache.iceberg.actions.RewriteDataFiles.FileGroupInfo,\
+        \ java.util.List<org.apache.iceberg.FileScanTask>)"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method void org.apache.iceberg.actions.RewritePositionDeletesGroup::<init>(org.apache.iceberg.actions.RewritePositionDeleteFiles.FileGroupInfo,\
+        \ java.util.List<org.apache.iceberg.PositionDeletesScanTask>)"
+      justification: "Removing deprecations for 1.10.0"
+    org.apache.iceberg:iceberg-parquet:
+    - code: "java.method.removed"
+      old: "method <T extends org.apache.iceberg.StructLike> org.apache.iceberg.parquet.ParquetValueWriter<T>\
+        \ org.apache.iceberg.data.parquet.InternalWriter<T extends org.apache.iceberg.StructLike>::create(org.apache.parquet.schema.MessageType)"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method <T extends org.apache.iceberg.StructLike> org.apache.iceberg.parquet.ParquetValueWriters.StructWriter<T>\
+        \ org.apache.iceberg.parquet.ParquetValueWriters::recordWriter(java.util.List<org.apache.iceberg.parquet.ParquetValueWriter<?>>)"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method org.apache.iceberg.parquet.ParquetValueReader<T> org.apache.iceberg.data.parquet.InternalReader<T\
+        \ extends org.apache.iceberg.StructLike>::createStructReader(java.util.List<org.apache.parquet.schema.Type>,\
+        \ java.util.List<org.apache.iceberg.parquet.ParquetValueReader<?>>, org.apache.iceberg.types.Types.StructType)"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method org.apache.iceberg.parquet.ParquetValueReader<org.apache.iceberg.data.Record>\
+        \ org.apache.iceberg.data.parquet.GenericParquetReaders::createStructReader(java.util.List<org.apache.parquet.schema.Type>,\
+        \ java.util.List<org.apache.iceberg.parquet.ParquetValueReader<?>>, org.apache.iceberg.types.Types.StructType)"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method org.apache.iceberg.parquet.ParquetValueWriter<org.apache.iceberg.data.Record>\
+        \ org.apache.iceberg.data.parquet.GenericParquetWriter::buildWriter(org.apache.parquet.schema.MessageType)"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method org.apache.iceberg.parquet.ParquetValueWriters.StructWriter<T>\
+        \ org.apache.iceberg.data.parquet.InternalWriter<T extends org.apache.iceberg.StructLike>::createStructWriter(java.util.List<org.apache.iceberg.parquet.ParquetValueWriter<?>>)"
+      justification: "Removing deprecations for 1.10.0"
+    - code: "java.method.removed"
+      old: "method org.apache.iceberg.parquet.ParquetValueWriters.StructWriter<org.apache.iceberg.data.Record>\
+        \ org.apache.iceberg.data.parquet.GenericParquetWriter::createStructWriter(java.util.List<org.apache.iceberg.parquet.ParquetValueWriter<?>>)"
+      justification: "Removing deprecations for 1.10.0"
   apache-iceberg-0.14.0:
     org.apache.iceberg:iceberg-api:
     - code: "java.class.defaultSerializationChanged"

aws/src/main/java/org/apache/iceberg/aws/RESTSigV4Signer.java

@@ -134,47 +134,6 @@ public GenericManifestFile(Schema avroSchema) {
     this.firstRowId = firstRowId;
   }
 
-  /**
-   * GenericManifestFile constructor.
-   *
-   * @deprecated will be removed in 1.10.0; use {@link ManifestWriter#toManifestFile()} instead.
-   */
-  @Deprecated
-  public GenericManifestFile(
-      String path,
-      long length,
-      int specId,
-      ManifestContent content,
-      long sequenceNumber,
-      long minSequenceNumber,
-      Long snapshotId,
-      int addedFilesCount,
-      long addedRowsCount,
-      int existingFilesCount,
-      long existingRowsCount,
-      int deletedFilesCount,
-      long deletedRowsCount,
-      List<PartitionFieldSummary> partitions,
-      ByteBuffer keyMetadata) {
-    super(ManifestFile.schema().columns().size());
-    this.avroSchema = AVRO_SCHEMA;
-    this.manifestPath = path;
-    this.length = length;
-    this.specId = specId;
-    this.content = content;
-    this.sequenceNumber = sequenceNumber;
-    this.minSequenceNumber = minSequenceNumber;
-    this.snapshotId = snapshotId;
-    this.addedFilesCount = addedFilesCount;
-    this.addedRowsCount = addedRowsCount;
-    this.existingFilesCount = existingFilesCount;
-    this.existingRowsCount = existingRowsCount;
-    this.deletedFilesCount = deletedFilesCount;
-    this.deletedRowsCount = deletedRowsCount;
-    this.partitions = partitions == null ? null : partitions.toArray(new PartitionFieldSummary[0]);
-    this.keyMetadata = ByteBuffers.toByteArray(keyMetadata);
-  }
-
   /**
    * Copy constructor.
    *

core/src/main/java/org/apache/iceberg/GenericManifestFile.java

@@ -329,31 +329,13 @@ public void applyTo(TableMetadata.Builder metadataBuilder) {
     }
   }
 
-  /**
-   * @deprecated since 1.9.0, will be removed in 1.10.0; Use {@link MetadataUpdate.RemoveSnapshots}
-   *     instead.
-   */
-  @Deprecated
-  class RemoveSnapshot implements MetadataUpdate {
-    private final long snapshotId;
-
-    public RemoveSnapshot(long snapshotId) {
-      this.snapshotId = snapshotId;
-    }
-
-    public long snapshotId() {
-      return snapshotId;
-    }
-
-    @Override
-    public void applyTo(TableMetadata.Builder metadataBuilder) {
-      metadataBuilder.removeSnapshots(ImmutableSet.of(snapshotId));
-    }
-  }
-
   class RemoveSnapshots implements MetadataUpdate {
     private final Set<Long> snapshotIds;
 
+    public RemoveSnapshots(long snapshotId) {
+      this.snapshotIds = ImmutableSet.of(snapshotId);
+    }
+
     public RemoveSnapshots(Set<Long> snapshotIds) {
       this.snapshotIds = snapshotIds;
     }
@@ -577,17 +559,4 @@ public void applyTo(TableMetadata.Builder builder) {
       builder.removeEncryptionKey(keyId);
     }
   }
-
-  /**
-   * Update to enable row lineage.
-   *
-   * @deprecated will be removed in 1.10.0; row lineage is required for all v3+ tables.
-   */
-  @Deprecated
-  class EnableRowLineage implements MetadataUpdate {
-    @Override
-    public void applyTo(TableMetadata.Builder metadataBuilder) {
-      metadataBuilder.enableRowLineage();
-    }
-  }
 }