feat(group): add SetNotFoundHandle support for router groups#290
Merged
Conversation
- Add SetNotFoundHandle method to Group interface - Add notFoundHandler field to xGroup struct - Group-level NotFoundHandler takes priority over app-level - Update server.groups type from []Group to []*xGroup Resolves: #229
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Usage Example
Behavior
/api/users→ Returns "Users list"/api/unknown→ Returns "API 404 - Resource not found" (group handler)/unknown→ Returns global 404 (app handler)Test Plan
All existing tests pass
Manual testing with example code
Verify group 404 handler priority
Verify fallback to app-level handler
Resolves: #229