Add ubi-base based on ubi10#237
Conversation
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
5fafed5 to
022fc16
Compare
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
|
Pull Request UBI 10 images published ✨ Base Image: quay.io/devfile/base-developer-image:ubi10-pr-237 |
|
Pull Request images published ✨ |
| @@ -0,0 +1,55 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
There appears to be duplication between ubi9/ and ubi10/. Would it make sense to factor out shared scripts (e.g. kubedock_setup.sh, podman-wrapper.sh) into a common location to reduce duplication and ease maintenance?
There was a problem hiding this comment.
I kept this duplication on purpose, so that after switching to ubi10, we can delete the ubi9/ directory.
@dkwon17 Is this approach correct?
There was a problem hiding this comment.
Yes, eventually I'd imagine we will deprecate ubi9 sometime after fully adopting ubi10, just like we did for ubi8
| | `wget` |`wget` |`wget` | | ||
| | `zip` |`zip` |`zip` | | ||
| | `zsh` |`NOT AVAILABLE (fedora only)` |`NOT AVAILABLE (fedora only)` | | ||
| | **TOTAL SIZE** | **903MB** (341MB compressed) | **TODO** | |
There was a problem hiding this comment.
Will this be updated with final values or any additional notes before merging the PR?
There was a problem hiding this comment.
As for me this info is redundant in README.md:
- It requires manual updates whenever we install or remove something, which is easy to forget.
- The value may differ across architectures.
- If anyone needs this detail, they can always find it on quay.io, where the image is published
There was a problem hiding this comment.
@dkwon17 can we remove the image size info?
| echo user:10000:65536 > /etc/subgid | ||
|
|
||
| # Adjust storage.conf to enable Fuse storage. | ||
| RUN sed -i -e 's|^#mount_program|mount_program|g' -e '/additionalimage.*/a "/var/lib/shared",' /usr/share/containers/storage.conf |
There was a problem hiding this comment.
In the base/ubi9 image, I noticed that the storage.conf file path /etc/containers/storage.conf
Is this location supposed to be different for UBI9 and UBI10?
There was a problem hiding this comment.
In ubi10 there is no /etc/containers/storage.conf so used the default distribution-provided configuration file, which is /usr/share/containers/storage.conf. Now I understand that the correct approach would have been to copy the default storage.conf to /etc/containers/.
I also noticed that the entrypoint.sh creates a new config that takes precedence over the system-wide ones:
developer-images/base/ubi10/entrypoint.sh
Lines 14 to 22 in 699a882
It looks like this modifications to storage.conf in the Dockerfile are dead code.
|
|
||
| # Add kubedock | ||
| # See release page for details https://github.com/joyrex2001/kubedock/releases/tag/0.18.1 | ||
| ENV KUBEDOCK_VERSION 0.18.1 |
There was a problem hiding this comment.
Could we also incorporate the changes from #235 as well?
There was a problem hiding this comment.
I'm preparing a fixup for this.
|
Thank you @akurinnoy , What I've successfully tested so far:
|
|
Pull Request UBI 10 images published ✨ Base Image: quay.io/devfile/base-developer-image:ubi10-pr-237 |
|
Pull Request images published ✨ |
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
699a882 to
fab1905
Compare
|
Pull Request UBI 10 images published ✨ Base Image: quay.io/devfile/base-developer-image:ubi10-pr-237 |
|
Pull Request images published ✨ |
|
I tested the PR using devfile, and it seems to be working
Installed Tools
|
| | `wget` |`wget` |`wget` | | ||
| | `zip` |`zip` |`zip` | | ||
| | `zsh` |`NOT AVAILABLE (fedora only)` |`NOT AVAILABLE (fedora only)` | | ||
| | **TOTAL SIZE** | **903MB** (341MB compressed) | **TODO** | |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, dkwon17 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
feat: Use latest upstream UBI9 image, update kubedock and gh-cli Signed-off-by: Ivan Suftin <isuftin@usgs.gov> feat: Update /etc/sub*id files to support nested containers (devfile#232) * feat: Update /etc/sub*id files in order to run podman command in a user namespace Signed-off-by: Anatolii Bazko <abazko@redhat.com> feat: Use latest upstream UBI9 image, update kubedock and gh-cli (devfile#235) Signed-off-by: Ivan Suftin <isuftin@usgs.gov> Add ubi-base based on ubi10 (devfile#237) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> chore: Import certificates on the start (devfile#240) * chore: Import certificates on the start Signed-off-by: Anatolii Bazko <abazko@redhat.com> chore: set Node 20 as a default version (devfile#229) Signed-off-by: Valerii <vsvydenk@redhat.com> Update base ubi9 image to latest Update GH CLI release Update ripgrep Update bat Update fd Update kubedock Update base/ubi9/Dockerfile Fix the upstream Docker image identifier Co-authored-by: David Kwon <dakwon@redhat.com>
feat: Use latest upstream UBI9 image, update kubedock and gh-cli Signed-off-by: Ivan Suftin <isuftin@usgs.gov> feat: Update /etc/sub*id files to support nested containers (devfile#232) * feat: Update /etc/sub*id files in order to run podman command in a user namespace Signed-off-by: Anatolii Bazko <abazko@redhat.com> feat: Use latest upstream UBI9 image, update kubedock and gh-cli (devfile#235) Signed-off-by: Ivan Suftin <isuftin@usgs.gov> Add ubi-base based on ubi10 (devfile#237) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> chore: Import certificates on the start (devfile#240) * chore: Import certificates on the start Signed-off-by: Anatolii Bazko <abazko@redhat.com> chore: set Node 20 as a default version (devfile#229) Signed-off-by: Valerii <vsvydenk@redhat.com> Update base ubi9 image to latest Update GH CLI release Update ripgrep Update bat Update fd Update kubedock Update base/ubi9/Dockerfile Fix the upstream Docker image identifier Co-authored-by: David Kwon <dakwon@redhat.com>
feat: Use latest upstream UBI9 image, update kubedock and gh-cli Signed-off-by: Ivan Suftin <isuftin@usgs.gov> feat: Update /etc/sub*id files to support nested containers (devfile#232) * feat: Update /etc/sub*id files in order to run podman command in a user namespace Signed-off-by: Anatolii Bazko <abazko@redhat.com> feat: Use latest upstream UBI9 image, update kubedock and gh-cli (devfile#235) Signed-off-by: Ivan Suftin <isuftin@usgs.gov> Add ubi-base based on ubi10 (devfile#237) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> chore: Import certificates on the start (devfile#240) * chore: Import certificates on the start Signed-off-by: Anatolii Bazko <abazko@redhat.com> chore: set Node 20 as a default version (devfile#229) Signed-off-by: Valerii <vsvydenk@redhat.com> Update base ubi9 image to latest Update GH CLI release Update ripgrep Update bat Update fd Update kubedock Update base/ubi9/Dockerfile Fix the upstream Docker image identifier Co-authored-by: David Kwon <dakwon@redhat.com> Signed-off-by: Ivan Suftin <isuftin@usgs.gov>
This PR introduces new
ubi-baseimage based onubi10. It adds GH workflows for production builds and for PR validations. BuildingUDIbased onubi10is disabled so far.This PR also enhances GH workflows to make them fork-friendly:
One can set repository variable
REGISTRYto their custom registry (e.g.quay.io/yourusername). Otherwise, the fallback registry (quay.io/devfile) will be used.How to test
Create a DevWorkspace, it should start successfully:
Devfile
link: https://gist.github.com/akurinnoy/afccc6da6105a5c87911acb648bb88a9/raw/c83a1952c939ca51bd847d70a1f32158554f50e4/ubi10-base
DevWorkspace
Open Che Code and check if all the development tools are included, see https://github.com/devfile/developer-images/blob/86af50296b6c4187376feea5e22a9e993fbb00e5/README.md#included-development-tools
Check (thanks @dkwon17 ):
podman build -t hello https://github.com/containers/PodmanHello.git)podman run quay.io/dkwon17/test:1234)How to get image size