Fix: check for empty storage in common storage provisioner

The NeedsStorage always return false for per-wokrspace storage. This
causes an issue and per-workspace workspaces are never backed up.

Moving the check to commonStorage only fixes the issue and still works
with empty workspaces.

Signed-off-by: Ales Raszka <araszka@redhat.com>

Author: Allda

pkg/library/storage/storage.go

@@ -49,16 +49,16 @@ func GetWorkspacePVCInfo(
 	if err != nil {
 		return "", "", err
 	}
-	if !storageProvisioner.NeedsStorage(&workspace.Spec.Template) {
-		// No storage provisioned for this workspace
-		return "", "", nil
-	}
 
 	if _, ok := storageProvisioner.(*storage.PerWorkspaceStorageProvisioner); ok {
 		pvcName := common.PerWorkspacePVCName(workspace.Status.DevWorkspaceId)
 		return pvcName, constants.DefaultProjectsSourcesRoot, nil
 
 	} else if _, ok := storageProvisioner.(*storage.CommonStorageProvisioner); ok {
+		if !storageProvisioner.NeedsStorage(&workspace.Spec.Template) {
+			// No storage provisioned for this workspace
+			return "", "", nil
+		}
 		pvcName := constants.DefaultWorkspacePVCName
 		if config.Workspace != nil && config.Workspace.PVCName != "" {
 			pvcName = config.Workspace.PVCName