Give system:image-builder role to backup cron job SA

dkwon17 · dkwon17 · commit 460cd250eecd · 2026-02-09T16:40:35.000-05:00
Signed-off-by: David Kwon &lt;dakwon@redhat.com&gt;
diff --git a/controllers/backupcronjob/rbac.go b/controllers/backupcronjob/rbac.go
@@ -99,7 +99,7 @@ func (r *BackupCronJobReconciler) ensureImagePushRoleBinding(ctx context.Context
 		},
 		RoleRef: rbacv1.RoleRef{
 			Kind:     constants.RbacClusterRoleKind,
-			Name:     common.RegistryImagePullerRoleName(),
+			Name:     common.RegistryImageBuilderRoleName(),
 			APIGroup: "rbac.authorization.k8s.io",
 		},
 	}
diff --git a/pkg/common/naming.go b/pkg/common/naming.go
@@ -160,7 +160,11 @@ func WorkspaceSCCRolebindingName(sccName string) string {
 }
 
 func RegistryImagePullerRoleName() string {
-	return fmt.Sprintf("system:image-puller")
+	return "system:image-puller"
+}
+
+func RegistryImageBuilderRoleName() string {
+	return "system:image-builder"
 }
 
 func RegistryImagePullerRolebindingName(namespace string) string {

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ func (r *BackupCronJobReconciler) ensureImagePushRoleBinding(ctx context.Context`
`99`	`99`	`},`
`100`	`100`	`RoleRef: rbacv1.RoleRef{`
`101`	`101`	`Kind: constants.RbacClusterRoleKind,`
`102`		`- Name: common.RegistryImagePullerRoleName(),`
	`102`	`+ Name: common.RegistryImageBuilderRoleName(),`
`103`	`103`	`APIGroup: "rbac.authorization.k8s.io",`
`104`	`104`	`},`
`105`	`105`	`}`
Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,11 @@ func WorkspaceSCCRolebindingName(sccName string) string {`
`160`	`160`	`}`
`161`	`161`
`162`	`162`	`func RegistryImagePullerRoleName() string {`
`163`		`- return fmt.Sprintf("system:image-puller")`
	`163`	`+ return "system:image-puller"`
	`164`	`+}`
	`165`	`+`
	`166`	`+func RegistryImageBuilderRoleName() string {`
	`167`	`+ return "system:image-builder"`
`164`	`168`	`}`
`165`	`169`
`166`	`170`	`func RegistryImagePullerRolebindingName(namespace string) string {`