Update code to remove incompatibilities with new dependencies

* Replace corev1.Handler with corev1.LifecycleHandler or ProbeHandler as
  required
* Replace k8s.io/apimachinery/pkg/util/clock with k8s.io/utils/clock

Signed-off-by: Angel Misevski <amisevsk@redhat.com>

Author: amisevsk

controllers/workspace/status.go

@@ -31,7 +31,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	k8sErrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	kubeclock "k8s.io/apimachinery/pkg/util/clock"
+	kubeclock "k8s.io/utils/clock"
 	"sigs.k8s.io/controller-runtime/pkg/reconcile"
 
 	"github.com/devfile/devworkspace-operator/apis/controller/v1alpha1"

controllers/workspace/util_test.go

@@ -32,7 +32,7 @@ import (
 	k8sErrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
-	kubeclock "k8s.io/apimachinery/pkg/util/clock"
+	kubeclock "k8s.io/utils/clock"
 )
 
 const (

pkg/library/lifecycle/poststart.go

@@ -66,7 +66,7 @@ func AddPostStartLifecycleHooks(wksp *dw.DevWorkspaceTemplateSpec, containers []
 	return nil
 }
 
-func processCommandForPostStart(command *dw.ExecCommand) (*corev1.Handler, error) {
+func processCommandForPostStart(command *dw.ExecCommand) (*corev1.LifecycleHandler, error) {
 	cmd := []string{"/bin/sh", "-c"}
 
 	if len(command.Env) > 0 {
@@ -81,7 +81,7 @@ func processCommandForPostStart(command *dw.ExecCommand) (*corev1.Handler, error
 
 	cmd = append(cmd, strings.Join(fullCmd, "\n"))
 
-	handler := &corev1.Handler{
+	handler := &corev1.LifecycleHandler{
 		Exec: &corev1.ExecAction{
 			Command: cmd,
 		},

pkg/provision/storage/asyncstorage/sidecar.go

@@ -77,7 +77,7 @@ func GetAsyncSidecar(devworkspaceID, sshVolumeName string, volumes []corev1.Volu
 		},
 		VolumeMounts: volumeMounts,
 		Lifecycle: &corev1.Lifecycle{
-			PreStop: &corev1.Handler{
+			PreStop: &corev1.LifecycleHandler{
 				Exec: &corev1.ExecAction{
 					Command: []string{"/bin/sh", "-c", "/scripts/backup.sh"},
 				},

pkg/provision/workspace/rbac/common_test.go

@@ -25,7 +25,7 @@ import (
 	"github.com/devfile/devworkspace-operator/pkg/config"
 	"github.com/devfile/devworkspace-operator/pkg/constants"
 	"github.com/devfile/devworkspace-operator/pkg/provision/sync"
-	testlog "github.com/go-logr/logr/testing"
+	"github.com/go-logr/logr/testr"
 	"github.com/stretchr/testify/assert"
 	rbacv1 "k8s.io/api/rbac/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -175,7 +175,7 @@ func getTestClusterAPI(t *testing.T, initialObjects ...client.Object) sync.Clust
 		Ctx:    context.Background(),
 		Client: fakeClient,
 		Scheme: scheme,
-		Logger: testlog.TestLogger{T: t},
+		Logger: testr.New(t),
 	}
 }
 

pkg/webhook/deployment.go

@@ -128,7 +128,7 @@ func getSpecDeployment(webhooksSecretName, namespace string) (*appsv1.Deployment
 							Args:            []string{"/usr/local/bin/webhook-server", "--metrics-addr=127.0.0.1:8080"},
 							ImagePullPolicy: corev1.PullAlways,
 							LivenessProbe: &corev1.Probe{
-								Handler: corev1.Handler{
+								ProbeHandler: corev1.ProbeHandler{
 									HTTPGet: &corev1.HTTPGetAction{
 										Path:   "/healthz",
 										Port:   intstr.FromString("liveness-port"),
@@ -142,7 +142,7 @@ func getSpecDeployment(webhooksSecretName, namespace string) (*appsv1.Deployment
 								FailureThreshold:    5,
 							},
 							ReadinessProbe: &corev1.Probe{
-								Handler: corev1.Handler{
+								ProbeHandler: corev1.ProbeHandler{
 									HTTPGet: &corev1.HTTPGetAction{
 										Path:   "/readyz",
 										Port:   intstr.FromString("liveness-port"),