fix: common PVC cleanup job to be assigned to a correct node#1415
Merged
akurinnoy merged 3 commits intodevfile:mainfrom Jun 6, 2025
Merged
fix: common PVC cleanup job to be assigned to a correct node#1415akurinnoy merged 3 commits intodevfile:mainfrom
akurinnoy merged 3 commits intodevfile:mainfrom
Conversation
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
|
Skipping CI for Draft Pull Request. |
Collaborator
|
/retest |
rohanKanojia
reviewed
May 4, 2025
Co-authored-by: Rohan Kumar <rohan.kumar.kanojia@gmail.com> Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
rohanKanojia
approved these changes
May 7, 2025
dkwon17
approved these changes
Jun 3, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akurinnoy, dkwon17, rohanKanojia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dkwon17
reviewed
Jun 4, 2025
Collaborator
|
@akurinnoy I've tested on a single node and multi node cluster, I just have one small suggestion |
|
New changes are detected. LGTM label has been removed. |
Co-authored-by: David Kwon <dakwon@redhat.com> Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Collaborator
|
Thank you @akurinnoy , please squash and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request enhances the common PVC cleanup job by adding node affinity rule.
This change modifies the cleanup job creation logic to:
volume.kubernetes.io/selected-nodeannotation from the common PVC associated with the DevWorkspace.requiredDuringSchedulingIgnoredDuringExecutionnode affinity rule to the cleanup job's pod spec, targeting the specified node.This ensures that the cleanup job pod runs on the same node as the volume. If the annotation is not present, no node affinity is added.
What issues does this PR fix or reference?
resolves #1269
Is it tested? How?
volume.kubernetes.io/selected-nodeannotation. Note the node name specified in the annotation value.nodeSelectorTermstarget the node name noted in step 2 via thekubernetes.io/hostnamekey.PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che