chore: fix Dockerfile warnings reported during docker build#1416
Merged
dkwon17 merged 1 commit intodevfile:mainfrom May 3, 2025
Merged
chore: fix Dockerfile warnings reported during docker build#1416dkwon17 merged 1 commit intodevfile:mainfrom
dkwon17 merged 1 commit intodevfile:mainfrom
Conversation
- Use uppercase keyword in dockerfile as per convention - Split long RUN instruction into multiple lines for clarity - Use exec form for CMD instruction as done in ENTRYPOINT Signed-off-by: Rohan Kumar <rohaan@redhat.com>
|
Skipping CI for Draft Pull Request. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| # https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9/go-toolset | ||
| FROM registry.access.redhat.com/ubi9/go-toolset:9.5-1739267472 as builder | ||
| FROM registry.access.redhat.com/ubi9/go-toolset:9.5-1739267472 AS builder |
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium
rohanKanojia
requested review from
akurinnoy,
dkwon17 and
ibuziuk
as code owners
Collaborator
|
/retest |
dkwon17
approved these changes
May 2, 2025
dkwon17
approved these changes
May 3, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkwon17, rohanKanojia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR tries to fix build warnings seen during
make dockercommand invocation:What issues does this PR fix or reference?
It doesn't fix any related issue. It's only a minor cleanup task.
Is it tested? How?
Without these changes you'd see the warnings reported above when running
make docker.I've verified that after making changes, I don't see any warnings.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che