Configuring the DevWorkspace Cleanup Job#1421
Merged
akurinnoy merged 1 commit intodevfile:mainfrom May 1, 2025
Merged
Conversation
bb89a39 to
df275b3
Compare
ibuziuk
reviewed
Apr 29, 2025
ibuziuk
approved these changes
Apr 29, 2025
b995123 to
e10ee42
Compare
dkwon17
reviewed
Apr 29, 2025
dkwon17
reviewed
Apr 29, 2025
dkwon17
reviewed
Apr 29, 2025
dkwon17
reviewed
Apr 29, 2025
rohanKanojia
approved these changes
Apr 30, 2025
09d0d3c to
252fa92
Compare
dkwon17
reviewed
Apr 30, 2025
dkwon17
reviewed
Apr 30, 2025
dkwon17
approved these changes
Apr 30, 2025
Collaborator
dkwon17
left a comment
There was a problem hiding this comment.
@akurinnoy sorry I missed a couple more suggestions. After fixing these, please merge this PR, thank you
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akurinnoy, dkwon17, ibuziuk, rohanKanojia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
252fa92 to
a6c6d48
Compare
|
New changes are detected. LGTM label has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a "Configuring Cleanup Job" section to the
docs/dwo-configuration.md.What issues does this PR fix or reference?
Is it tested? How?
n/a
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che