feat : [CRW-5722] Add configuration option in DevWorkspaceOperatorConfig for storage access mode (#1019)#1430
Merged
dkwon17 merged 2 commits intodevfile:mainfrom Jun 12, 2025
Conversation
|
Skipping CI for Draft Pull Request. |
49a6774 to
9de9d22
Compare
Member
Author
|
/ok-to-test |
a36b8fb to
cfb338e
Compare
Member
Author
|
/ok-to-test |
cfb338e to
c024f83
Compare
Member
Author
|
/ok-to-test |
Member
Author
|
/ok-to-test |
akurinnoy
approved these changes
May 15, 2025
ibuziuk
approved these changes
Jun 4, 2025
c024f83 to
91892d1
Compare
91892d1 to
0223f6c
Compare
Member
Author
|
/ok-to-test |
- Add configuration option named StorageAccessMode in WorkspaceConfig struct Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…fig for storage access mode (devfile#1019) Set PVC accessMode if abovementioned option is set in WorkspaceConfig, default to ReadWriteOnce Signed-off-by: Rohan Kumar <rohaan@redhat.com>
0223f6c to
0016778
Compare
dkwon17
approved these changes
Jun 12, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akurinnoy, dkwon17, ibuziuk, rohanKanojia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fix #1019
Related to https://issues.redhat.com/browse/CRW-5722
Is it tested? How?
ReadWriteManyPR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che