test : fix flaky failures in sync_test by making sure non-empty string pointer is generated#1464
Merged
dkwon17 merged 1 commit intodevfile:mainfrom Jul 28, 2025
Merged
Conversation
…g pointer is generated Previosly in `fuzzStringPtr`, we were skipping assigning value of the generated string was empty. This was causing flaky behavior in test as mergeConfig logic checks if pointer is non-nil before merging a value. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
|
Skipping CI for Draft Pull Request. |
Member
Author
|
/ok-to-test |
dkwon17
approved these changes
Jul 28, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkwon17, rohanKanojia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously in
fuzzStringPtr, we were skipping assigning the value of the generated string was empty, meaningstrremainednil. This was causing flaky behavior in the test asmergeConfiglogic checks if the pointer is non-nil before merging a value.The updated
fuzzStringPtrfunction ensures that the pointer is always set and never set to an empty string. It guarantees that all fuzzed*stringfields are non-nil and non-empty, ensuring mergeConfig includes them during merging.We have a test for Proxy field values to cover
nilproxy value scenarios:devworkspace-operator/pkg/config/sync_test.go
Line 359 in f45fd01
I've added similar tests for other
*stringfields likeStorageClassNameandRuntimeClassNameWhat issues does this PR fix or reference?
Fix #1443
Is it tested? How?
I ran this test over 50 times, and it seems to pass on all attempts with these changes.
As per old changes, I saw 8 failures on 50 runs.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che