-
Notifications
You must be signed in to change notification settings - Fork 69
Remove unused chectl flag #1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
76d3cd5
Remove unused chectl flag
dkwon17 5f1880b
Increase podreadytimeout
dkwon17 f38176c
Increase podreadytimeout
dkwon17 a2b5c4e
Set podwaittimeout and podreadytimeout
dkwon17 b6c668e
Add --skip-devworkspace-operator since DWO is already installed
dkwon17 0196cd9
Remove unused flag
dkwon17 1bfa77c
Add jq in the e2e tests image
dkwon17 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that in che-operator we're using slightly longer timeout
--k8spodreadytimeout=6000000https://github.com/eclipse-che/che-operator/blob/d4a50d89668f6c08f56d9db627f996fd733971a5/build/scripts/minikube-tests/test-operator.sh#L36
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I will update the PR