Skip to content

chore (deps) : upgrade Go toolchain to 1.24.6#1507

Merged
dkwon17 merged 1 commit intodevfile:mainfrom
rohankanojia-forks:pr/bump-go-toolchain
Sep 24, 2025
Merged

chore (deps) : upgrade Go toolchain to 1.24.6#1507
dkwon17 merged 1 commit intodevfile:mainfrom
rohankanojia-forks:pr/bump-go-toolchain

Conversation

@rohanKanojia
Copy link
Copy Markdown
Member

@rohanKanojia rohanKanojia commented Sep 24, 2025

What does this PR do?

  • Updated Go version from 1.23.6 to 1.24.6 in GitHub Actions workflows:

    • .github/workflows/code-coverage.yml
    • .github/workflows/pr.yml
  • Updated go.mod toolchain directive from go 1.24.4 to go 1.24.6

  • Updated base image versions in Dockerfiles to match Go 1.24.6:

    • build/Dockerfile
    • project-clone/Dockerfile

What issues does this PR fix or reference?

Is it tested? How?

I just verified make test is passing. Will keep it as draft until CI checks are not passed.

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Comment thread build/Dockerfile Fixed
Comment thread project-clone/Dockerfile Fixed
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Comment thread build/Dockerfile

# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9/go-toolset
FROM registry.access.redhat.com/ubi9/go-toolset:1.24.4-1753853351 as builder
FROM registry.access.redhat.com/ubi9/go-toolset:1.24.6-1758501173 as builder

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating registry.access.redhat.com/ubi9/go-toolset:1.24.6-1758501173 to registry.access.redhat.com/ubi9/go-toolset:1.24.6-1758501173@sha256:84286c7555df503df0bd3acb86fe2ad50af82a07f35707918bb0fad312fdc193
Click Remediation section below for further remediation help
Comment thread project-clone/Dockerfile
# Build the manager binary
# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9/go-toolset
FROM registry.access.redhat.com/ubi9/go-toolset:1.24.4-1753853351 as builder
FROM registry.access.redhat.com/ubi9/go-toolset:1.24.6-1758501173 as builder

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating registry.access.redhat.com/ubi9/go-toolset:1.24.6-1758501173 to registry.access.redhat.com/ubi9/go-toolset:1.24.6-1758501173@sha256:84286c7555df503df0bd3acb86fe2ad50af82a07f35707918bb0fad312fdc193
Click Remediation section below for further remediation help
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.08%. Comparing base (8f2d764) to head (93ff29e).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1507      +/-   ##
==========================================
+ Coverage   34.05%   34.08%   +0.02%     
==========================================
  Files         160      160              
  Lines       13336    13348      +12     
==========================================
+ Hits         4542     4549       +7     
- Misses       8484     8489       +5     
  Partials      310      310              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rohanKanojia
Copy link
Copy Markdown
Member Author

/ok-to-test

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, rohanKanojia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohanKanojia
Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@rohanKanojia
Copy link
Copy Markdown
Member Author

/retest

@dkwon17
Copy link
Copy Markdown
Collaborator

dkwon17 commented Sep 24, 2025

@rohanKanojia thank you, LGTM, merging

@dkwon17 dkwon17 merged commit b35e79b into devfile:main Sep 24, 2025
13 checks passed
@rohanKanojia rohanKanojia deleted the pr/bump-go-toolchain branch September 24, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants