Make container status check less restrictive

[dkwon17]

What does this PR do?

Fixes issue with workspace restarts.

The issue with workspace restarts happens when the new CDE pod is starting when the previous CDE pod has not yet terminated. For example:

In this case, there is a temporary error with the new pod. The error has no error message, but looks like the following:

Container 'universal-developer-image' terminated with Error: 

This error seems to be occurring for only a few seconds, and dissappears in seconds. Although, I'm not too sure what is the root cause of this error.

Nevertheless, this PR reverts an error check that was done as part of #1440 to allow the DevWorkspace startup to not fail when restarting the DevWorkspace.

What issues does this PR fix or reference?

eclipse-che/che#23551

Is it tested? How?

1. Build and deploy the DWO with Eclipse Che.

The catalog source I used for testing is:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: devworkspace-operator-testing-catalog
  namespace: openshift-marketplace
spec:
  displayName: DevWorkspace Operator Catalog
  image: 'quay.io/dkwon17/devworkspace-operator-index:workspace-restart'
  publisher: DWO Testing
  sourceType: grpc

2. Create an empty workspace.
3. Wait until the workspace is running.
4. From the Che Dashboard, restart the running workspace.
5. Verify that the issue mentioned in Error at restarting workspace eclipse-che/che#23551 is not reproduced.
6. Verify that the post start timeout feature still works by following steps 2 and onwards from postStart hook commands timeout #1440.

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[rohanKanojia]

This PR should also fix #1508

The issue was intermittent within the E2E pipeline. I had initially suspected a configuration or stability problem with the CI infrastructure.

[rohanKanojia]

I tested this PR, and it seems to work as expected.

1. Restarted the empty workspace multiple times, and it restarted without throwing any errors.
2. Created a problematic workspace that timed out after the specified postStartTimeout of 30s

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akurinnoy, dkwon17, rohanKanojia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dkwon17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment