Skip to content

Sort automount configmaps and secrets to ensure deterministic ordering #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkwon17 merged 2 commits into from
Feb 9, 2026
Merged

Sort automount configmaps and secrets to ensure deterministic ordering #1578

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7728c25
Sort automount configmaps and secrets to ensure deterministic ordering
dkwon17 Jan 30, 2026
3913464
Add tests for sorting automount secrets and confimaps
dkwon17 Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/provision/automount/configmap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ func getDevWorkspaceConfigmaps(namespace string, api sync.ClusterAPI) (*Resource
}); err != nil {
return nil, err
}
sortConfigmaps(configmaps.Items)
var allAutoMountResouces []Resources
for _, configmap := range configmaps.Items {
if msg := checkAutomountVolumeForPotentialError(&configmap); msg != "" {
Expand Down
1 change: 1 addition & 0 deletions pkg/provision/automount/secret.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ func getDevWorkspaceSecrets(namespace string, api sync.ClusterAPI) (*Resources,
}); err != nil {
return nil, err
}
sortSecrets(secrets.Items)
var allAutoMountResouces []Resources
for _, secret := range secrets.Items {
if msg := checkAutomountVolumeForPotentialError(&secret); msg != "" {
Expand Down
Loading