add kaoto project#589
Conversation
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
|
Hi @maximilianoPizarro. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
|
This has happened every time @maximilianoPizarro has opened a PR: Being that @maximilianoPizarro is a stack owner, I'm thinking he should be added to devfile organization for this to pass, looking at the message given by the status check: |
@Jdubrick added me to Owners in the last PR from the other project. Thanks in Advance again @michael-valdron and team. |
This should be done for every new stack. So we should add this one here: https://github.com/devfile/registry/blob/main/.github/CODEOWNERS too. |
+1 having in mind that now he will be an owner of two stacks. |
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
thepetk
left a comment
There was a problem hiding this comment.
Needs review from the @devfile/che-team too
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
|
/retest-required |
|
/ok-to-test |
|
@maximilianoPizarro this is currently blocked by devfile/api#1702. I've already created a PR to address the issue so I'd say it will be unblocked soon. |
|
@maximilianoPizarro needs to be rebased to the latest main |
thepetk
left a comment
There was a problem hiding this comment.
In general lgtm, I'll aprove once all checks are passing
/ok-to-test
Excellent, thank you for everything. Have a nice weekend 🙌 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilianoPizarro, svor, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @Jdubrick , I just wanted to ask if the pending status on Kunflux is in any way related to the progress of the PR, or if I should simply wait for the remaining reviewers to take a look. Have a great week. Thanks in advance! |
|
/ok-to-test |
/needs-rebase Hi @maximilianoPizarro, I just resolved devfile/api#1740 now, if you rebase this check will pass. |
|
New changes are detected. LGTM label has been removed. |
|
/ok-to-test |
michael-valdron
left a comment
There was a problem hiding this comment.
@maximilianoPizarro Just notice the ownerships, I think we can hand ownership to you now ✅
Co-authored-by: Michael Valdron <michael.valdron@gmail.com> Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>
Co-authored-by: Michael Valdron <michael.valdron@gmail.com> Signed-off-by: Maximiliano Pizarro <maximiliano.pizarro.5@gmail.com>






Description of Changes
added kaoto project
How to test? (OpenShift DevSpaces)
From your Workspaces started, run the tasks from devfile, confirm the port to expose and open in browser:
optional: podman mode
Only run "tasks start-with-docker"