chore: Update nodejs-mongodb tools image tag#664
Conversation
|
Hi @vinokurig. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
The devfile from the starter project might be overriding the devfile in the registry, as I've seen in previous test failures on OpenShift it appears that the devfile in the starter project is still using 8.0.8 that was removed by the image maintainers without pinning the digest and as result OpenShift was unable to pull the database image: https://github.com/che-samples/nodejs-mongodb-sample/blob/18371d5988697f17ef51bc9c6ad48b7b431276b7/devfile.yaml#L24
Trying this in podman the pull fails:
$ podman pull bitnami/mongodb:8.0.8
Resolved "bitnami/mongodb" as an alias (/home/mvaldron/.cache/containers/short-name-aliases.conf)
Trying to pull docker.io/bitnami/mongodb:8.0.8...
Error: unable to copy from source docker://bitnami/mongodb:8.0.8: initializing source docker://bitnami/mongodb:8.0.8: reading manifest 8.0.8 in docker.io/bitnami/mongodb: manifest unknown
If the starter project devfile matches the devfile registry one the pull and tests should pass:
$ podman pull bitnami/mongodb@sha256:b3bd5b6be9a0734dfa027c866ba17c42fd4c4325c973669e5e77a354c30e84a3
mongodb@sha256:b3bd5b6be9a0734dfa027c866ba17c42fd4c4325c973669e5e77a354c30e84a3
Trying to pull docker.io/bitnami/mongodb@sha256:b3bd5b6be9a0734dfa027c866ba17c42fd4c4325c973669e5e77a354c30e84a3...
Getting image source signatures
Copying blob 66550a68e691 done |
Copying config 84aaff53f2 done |
Writing manifest to image destination
84aaff53f20c50bea77dfb215d2f1a344495c6f90fdaac0cb98cefbf83ca5c5
Signed-off-by: Ihor Vinokur <ivinokur@redhat.com>
|
@michael-valdron I have synchronized the mongo image in the che-samples project, could you please take a look. |
|
/ok-to-test |
|
@vinokurig: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, svor, vinokurig The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Description of Changes
Update nodejs-mongodb tools image tag to the latest.
Related Issue(s)
fixes eclipse-che/che#23717
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.