Skip to content

Commit 196a266

Browse files
densumeshskeptrunedev
authored andcommitted
bugfix: remove the filter on the searched products, bugfix: close modal after creating question
1 parent 165c778 commit 196a266

2 files changed

Lines changed: 28 additions & 38 deletions

File tree

clients/trieve-shopify-extension/app/components/settings/PresetQuestions.tsx

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,10 @@ export function PresetQuestions({ initialQuestions }: PresetQuestionsProps) {
136136
return;
137137
}
138138

139+
setEditFormData(defaultQuestionFormData);
140+
setSearchedProducts([]);
141+
setEditingQuestionId(null);
142+
setIsAddingNewQuestion(false);
139143
setPresetQuestions(updatedQuestions);
140144
submitPresetQuestions(updatedQuestions);
141145
shopify.toast.show("Preset question saved!");
@@ -205,20 +209,6 @@ export function PresetQuestions({ initialQuestions }: PresetQuestionsProps) {
205209
const results = await trieve.trieve.searchOverGroups({
206210
query: searchTerm,
207211
search_type: "fulltext",
208-
filters: {
209-
must: [
210-
{
211-
field: "metadata.status",
212-
match_all: ["ACTIVE"],
213-
},
214-
{
215-
field: "metadata.variant_inventory",
216-
range: {
217-
gt: 0,
218-
},
219-
},
220-
],
221-
},
222212
});
223213

224214
const apiResults: Product[] = results.results

clients/trieve-shopify-extension/app/routes/app._dashboard.experimentview.$experimentId.tsx

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -76,14 +76,14 @@ export async function loader({ request, params }: LoaderFunctionArgs) {
7676
},
7777
],
7878
})
79-
// .where({
80-
// column: "events.created_at",
81-
// operator: ">",
82-
// value: new Date(experiment.created_at)
83-
// .toISOString()
84-
// .slice(0, 19)
85-
// .replace("T", " "),
86-
// })
79+
.where({
80+
column: "events.created_at",
81+
operator: ">",
82+
value: new Date(experiment.created_at)
83+
.toISOString()
84+
.slice(0, 19)
85+
.replace("T", " "),
86+
})
8787
.where({
8888
column: "experiment_user_assignments.experiment_id",
8989
operator: "=",
@@ -136,14 +136,14 @@ export async function loader({ request, params }: LoaderFunctionArgs) {
136136
},
137137
],
138138
})
139-
// .where({
140-
// column: "events.created_at",
141-
// operator: ">",
142-
// value: new Date(experiment.created_at)
143-
// .toISOString()
144-
// .slice(0, 19)
145-
// .replace("T", " "),
146-
// })
139+
.where({
140+
column: "events.created_at",
141+
operator: ">",
142+
value: new Date(experiment.created_at)
143+
.toISOString()
144+
.slice(0, 19)
145+
.replace("T", " "),
146+
})
147147
.groupBy(["experiment_user_assignments.treatment_name"])
148148
.build();
149149

@@ -187,14 +187,14 @@ export async function loader({ request, params }: LoaderFunctionArgs) {
187187
},
188188
],
189189
})
190-
// .where({
191-
// column: "events.created_at",
192-
// operator: ">",
193-
// value: new Date(experiment.created_at)
194-
// .toISOString()
195-
// .slice(0, 19)
196-
// .replace("T", " "),
197-
// })
190+
.where({
191+
column: "events.created_at",
192+
operator: ">",
193+
value: new Date(experiment.created_at)
194+
.toISOString()
195+
.slice(0, 19)
196+
.replace("T", " "),
197+
})
198198
.groupBy(["experiment_user_assignments.treatment_name"])
199199
.build();
200200

0 commit comments

Comments
 (0)