Skip to content

Commit 40afeb7

Browse files
cdxkerskeptrunedev
authored andcommitted
bugfix(shopify): have shopify policies refresh, make loading spinner
stop after 90% of products are ingested, let policies get fed into the search
1 parent 64e5244 commit 40afeb7

File tree

5 files changed

+46
-11
lines changed

5 files changed

+46
-11
lines changed

clients/trieve-shopify-extension/app/components/onboarding/WelcomeOnboarding.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export const WelcomeOnboarding: OnboardingBody = ({
3131
if (!productVariantsCount || !usage?.chunk_count) {
3232
return;
3333
}
34-
if (usage?.chunk_count >= productVariantsCount) {
34+
if (usage?.chunk_count >= productVariantsCount * 0.1) {
3535
setCompleted(true);
3636
setRefetch(false);
3737
if (trieve.organizationId && trieve.trieve.apiKey != null) {

clients/trieve-shopify-extension/app/components/settings/DatasetSettings.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,13 @@ import {
88
Card,
99
Divider,
1010
FormLayout,
11-
Icon,
1211
InlineGrid,
1312
InlineStack,
14-
Page,
15-
Select,
1613
Text,
1714
TextField,
1815
useBreakpoints,
1916
} from "@shopify/polaris";
20-
import { CheckCircleIcon, InfoIcon } from "@shopify/polaris-icons";
17+
import { CheckCircleIcon } from "@shopify/polaris-icons";
2118
import { useClientAdminApi } from "app/loaders/clientLoader";
2219
import { setAppMetafields } from "app/queries/metafield";
2320
import { useCallback, useEffect, useState } from "react";
@@ -97,9 +94,6 @@ export const DatasetSettings = ({
9794
useState(initalCrawlOptions);
9895
const shopify = useAppBridge();
9996
const submit = useSubmit();
100-
const [datasetSettings, setDatasetSettings] = useState<DatasetConfig>(
101-
shopDataset.server_configuration ?? ({} as DatasetConfig),
102-
);
10397

10498
const adminApi = useClientAdminApi();
10599
const { smUp } = useBreakpoints();

clients/trieve-shopify-extension/app/components/settings/PolicySettings.tsx

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,11 @@ import {
1313
Modal,
1414
InlineGrid,
1515
} from "@shopify/polaris";
16-
import { useState, useCallback } from "react";
16+
import { useEffect, useState } from "react";
1717
import { Dataset } from "trieve-ts-sdk";
1818
import { useSubmit } from "@remix-run/react";
1919
import { PlusIcon, DeleteIcon, EditIcon } from "@shopify/polaris-icons";
20+
import { useTrieve } from "app/context/trieveContext";
2021

2122
interface Policy {
2223
id: string;
@@ -41,6 +42,7 @@ export function PolicySettings({
4142
});
4243
const [showDeleteConfirmModal, setShowDeleteConfirmModal] = useState(false);
4344
const [policyIdToDelete, setPolicyIdToDelete] = useState<string | null>(null);
45+
const trieve = useTrieve();
4446

4547
const submit = useSubmit();
4648

@@ -63,7 +65,7 @@ export function PolicySettings({
6365
};
6466
}
6567

66-
await submit(
68+
submit(
6769
{
6870
policy: policyToAdd.content,
6971
policy_id: policyToAdd.id,
@@ -91,6 +93,19 @@ export function PolicySettings({
9193
}
9294
};
9395

96+
useEffect(() => {
97+
trieve.trieve.getChunksGroupByTrackingId({
98+
groupTrackingId: "policy",
99+
page: 1
100+
}).then((res) => {
101+
const initialPolicies: Policy[] = res.chunks.filter((chunk) => chunk.chunk_html && chunk.tracking_id).map((chunk) => ({
102+
id: chunk.tracking_id ?? "",
103+
content: chunk.chunk_html || ""
104+
}))
105+
setPolicies(initialPolicies);
106+
});
107+
}, []);
108+
94109
const handleStartEditPolicy = (policy: Policy) => {
95110
setIsAdding(false);
96111
setEditingPolicyId(policy.id);

clients/trieve-shopify-extension/app/routes/app._dashboard.settings.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,8 +242,14 @@ export const action = async ({ request }: ActionFunctionArgs) => {
242242
});
243243

244244
await trieve.createChunk({
245+
// Add this just to rubber stamp
246+
metadata: {
247+
status: "ACTIVE",
248+
variant_inventory: 20,
249+
},
245250
chunk_html: policyContent as string,
246251
tracking_id: policyId as string,
252+
tag_set: ["policy"],
247253
group_tracking_ids: ["policy"],
248254
upsert_by_tracking_id: true,
249255
});

clients/trieve-shopify-extension/extensions/global-search/blocks/global_component.liquid

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,27 @@
103103
match_all: [
104104
"ACTIVE"
105105
]
106-
}
106+
},
107+
],
108+
should: [
109+
{
110+
field: "tag_set",
111+
match_any: [
112+
"policy"
113+
]
114+
},
115+
{
116+
field: "metadata.variant_inventory",
117+
range: {
118+
gt: 0
119+
}
120+
},
121+
{
122+
field: "metadata.status",
123+
match_all: [
124+
"ACTIVE"
125+
]
126+
},
107127
]
108128
},
109129
defaultCurrency: currencySymbol(currency),

0 commit comments

Comments
 (0)