Skip to content

Commit e82f47a

Browse files
committed
bugfix: ensure that all the fields are being inserted
1 parent e0e66e0 commit e82f47a

File tree

1 file changed

+18
-17
lines changed

1 file changed

+18
-17
lines changed

docker/collapse-query-script/collapse_queries.go

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,21 @@ import (
1919

2020
type SearchQuery struct {
2121
ID uuid.UUID
22-
Query string
23-
TopScore float64
24-
CreatedAt time.Time
2522
SearchType string
23+
Query string
2624
ReqParams string
2725
Latency float64
26+
TopScore float64
2827
Results []string
2928
QueryVector []float32
29+
DatasetID uuid.UUID
30+
CreatedAt time.Time
3031
IsDuplicate int
3132
QueryRating string
32-
DatasetID uuid.UUID
33+
UserID string
34+
Metadata string
35+
Tokens int
36+
OrgID string
3337
}
3438

3539
type DatasetLastCollapsed struct {
@@ -157,8 +161,7 @@ func getSearchQueries(conn *sql.DB, datasetID uuid.UUID, limit int, offset *time
157161

158162
if offset != nil {
159163
query = `
160-
SELECT id, query, top_score, created_at, search_type, request_params, latency, results,
161-
query_vector, is_duplicate, query_rating, dataset_id
164+
SELECT *
162165
FROM default.search_queries
163166
WHERE dataset_id = ? AND created_at >= ? AND search_type != 'rag'
164167
ORDER BY created_at DESC
@@ -167,8 +170,7 @@ func getSearchQueries(conn *sql.DB, datasetID uuid.UUID, limit int, offset *time
167170
args = []any{datasetID, *offset, limit}
168171
} else {
169172
query = `
170-
SELECT id, query, top_score, created_at, search_type, request_params, latency, results,
171-
query_vector, is_duplicate, query_rating, dataset_id
173+
SELECT *
172174
FROM default.search_queries
173175
WHERE dataset_id = ? AND is_duplicate = 0 AND search_type != 'rag'
174176
ORDER BY created_at DESC
@@ -187,9 +189,9 @@ func getSearchQueries(conn *sql.DB, datasetID uuid.UUID, limit int, offset *time
187189
for rows.Next() {
188190
var sq SearchQuery
189191
if err := rows.Scan(
190-
&sq.ID, &sq.Query, &sq.TopScore, &sq.CreatedAt, &sq.SearchType,
191-
&sq.ReqParams, &sq.Latency, &sq.Results, &sq.QueryVector,
192-
&sq.IsDuplicate, &sq.QueryRating, &sq.DatasetID,
192+
&sq.ID, &sq.SearchType, &sq.Query, &sq.ReqParams, &sq.Latency, &sq.TopScore,
193+
&sq.Results, &sq.QueryVector, &sq.DatasetID, &sq.CreatedAt, &sq.IsDuplicate,
194+
&sq.QueryRating, &sq.UserID, &sq.Metadata, &sq.Tokens, &sq.OrgID,
193195
); err != nil {
194196
return nil, fmt.Errorf("scan error: %v", err)
195197
}
@@ -324,9 +326,9 @@ func insertDuplicateRows(conn *sql.DB, duplicates []SearchQuery) error {
324326

325327
stmt, err := tx.Prepare(`
326328
INSERT INTO default.search_queries (
327-
id, query, top_score, created_at, search_type, request_params, latency,
328-
results, query_vector, is_duplicate, query_rating, dataset_id
329-
) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
329+
id, search_type, query, req_params, latency, top_score, results, query_vector,
330+
dataset_id, created_at, is_duplicate, query_rating, user_id, metadata, tokens, org_id
331+
) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
330332
`)
331333
if err != nil {
332334
tx.Rollback()
@@ -358,9 +360,8 @@ func insertDuplicateRows(conn *sql.DB, duplicates []SearchQuery) error {
358360
defer func() { <-sem }()
359361

360362
_, err := stmt.Exec(
361-
d.ID, d.Query, d.TopScore, d.CreatedAt, d.SearchType,
362-
d.ReqParams, d.Latency, d.Results, d.QueryVector,
363-
d.IsDuplicate, d.QueryRating, d.DatasetID,
363+
d.ID, d.SearchType, d.Query, d.ReqParams, d.Latency, d.TopScore, d.Results, d.QueryVector,
364+
d.DatasetID, d.CreatedAt, d.IsDuplicate, d.QueryRating, d.UserID, d.Metadata, d.Tokens, d.OrgID,
364365
)
365366

366367
if err != nil {

0 commit comments

Comments
 (0)