refactor: remove httpExtra from various function signatures and contexts for cleaner code

Author: NoOne7135

agent/simpleAgent.ts

@@ -4,7 +4,6 @@ import {
   logger,
   type AdminUser,
   type CompletionAdapter,
-  type HttpExtra,
   type IAdminForth,
 } from "adminforth";
 import { BaseCallbackHandler } from "@langchain/core/callbacks/base";
@@ -28,7 +27,6 @@ export const contextSchema = z.object({
   turnId: z.string(),
   abortSignal: z.custom<AbortSignal>().optional(),
   currentPage: z.custom<CurrentPageContext>().optional(),
-  httpExtra: z.custom<Pick<HttpExtra, "headers" | "cookies">>().optional(),
   emitToolCallEvent: z.custom<ToolCallEventSink>(),
 });
 
@@ -235,7 +233,6 @@ export async function callAgent(params: {
   sessionId: string;
   turnId: string;
   currentPage?: CurrentPageContext;
-  httpExtra?: Pick<HttpExtra, "headers" | "cookies">;
   userTimeZone: string;
   abortSignal?: AbortSignal;
   emitToolCallEvent: ToolCallEventSink;
@@ -255,7 +252,6 @@ export async function callAgent(params: {
     sessionId,
     turnId,
     currentPage,
-    httpExtra,
     userTimeZone,
     abortSignal,
     emitToolCallEvent,
@@ -303,7 +299,6 @@ export async function callAgent(params: {
       turnId,
       abortSignal,
       currentPage,
-      httpExtra,
       emitToolCallEvent,
     },
   });

agent/toolCallEvents.ts

@@ -1,6 +1,5 @@
 import { randomUUID } from "crypto";
 import YAML from "yaml";
-import { serializeUnknownError } from "../apiBasedTools.js";
 
 export type ToolCallEvent =
   | {
@@ -61,6 +60,36 @@ function sanitizeToolCallOutputForDebug(output: unknown) {
   );
 }
 
+function serializeErrorForDebug(error: unknown): unknown {
+  if (!(error instanceof Error)) {
+    return error;
+  }
+
+  const errorWithCause = error as Error & { cause?: unknown };
+  const serialized: Record<string, unknown> = {
+    name: error.name,
+    message: error.message,
+  };
+
+  if (error.stack) {
+    serialized.stack = error.stack;
+  }
+
+  if (errorWithCause.cause !== undefined) {
+    serialized.cause = serializeErrorForDebug(errorWithCause.cause);
+  }
+
+  for (const key of Object.getOwnPropertyNames(error)) {
+    if (key in serialized) {
+      continue;
+    }
+
+    serialized[key] = (error as unknown as Record<string, unknown>)[key];
+  }
+
+  return serialized;
+}
+
 export function createToolCallTracker(params: {
   emit: ToolCallEventSink;
   toolCallId?: string;
@@ -99,7 +128,7 @@ export function createToolCallTracker(params: {
         phase: "end",
         durationMs: Date.now() - startedAt,
         output: null,
-        error: YAML.stringify(serializeUnknownError(error)).trimEnd(),
+        error: YAML.stringify(serializeErrorForDebug(error)).trimEnd(),
       });
     },
   };

agent/tools/apiTool.ts

@@ -52,7 +52,6 @@ export function createApiTool(toolName: string, apiBasedTool: ApiBasedTool) {
       return apiBasedTool.call({
         adminUser: runtime.context.adminUser,
         abortSignal: runtime.context.abortSignal,
-        httpExtra: runtime.context.httpExtra,
         inputs: normalizedInput,
         userTimeZone: runtime.context.userTimeZone,
       });