Skip to content

Commit caba74b

Browse files
committed
fix: simplify registerTaskHandler method and separate custom component registration
1 parent ca78085 commit caba74b

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

index.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -127,18 +127,18 @@ export default class extends AdminForthPlugin {
127127
return Promise.resolve(null);
128128
}
129129

130-
public registerTaskHandler(
131-
jobHandlerName: string,
132-
handler: taskHandlerType,
133-
customComponent?: AdminForthComponentDeclarationFull,
134-
parrallelLimit: number = 3,
135-
) {
130+
public registerTaskHandler({ jobHandlerName, handler, parallelLimit = 3,
131+
}:{jobHandlerName: string, handler: taskHandlerType, parallelLimit?: number}) {
136132
//register the handler in a map with jobHandlerName as key and handler as value
137133
this.taskHandlers[jobHandlerName] = handler;
138-
this.jobParallelLimits[jobHandlerName] = parrallelLimit;
139-
if (customComponent) {
140-
this.jobCustomComponents[jobHandlerName] = customComponent;
141-
}
134+
this.jobParallelLimits[jobHandlerName] = parallelLimit;
135+
}
136+
137+
public registerTaskDetailsComponent({
138+
jobHandlerName,
139+
component,
140+
}:{jobHandlerName: string, component: AdminForthComponentDeclarationFull}) {
141+
this.jobCustomComponents[jobHandlerName] = component;
142142
}
143143

144144
public async startNewJob(

0 commit comments

Comments
 (0)