refactor: add http proxy endpoints#2277
Merged
rsdmike merged 5 commits intoAug 26, 2025
Merged
Conversation
jaolanlo
changed the title
berosaso
force-pushed
the
get-post-http-proxy
branch
2 times, most recently
from
August 11, 2025 06:11
8848ddf to
4128486
Compare
berosaso
changed the title
berosaso
force-pushed
the
get-post-http-proxy
branch
from
August 11, 2025 19:04
1bc1bec to
810618a
Compare
berosaso
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds HTTP proxy configuration support by implementing API endpoints for creating and retrieving proxy profiles linked to AMT profiles. The implementation includes validation, database operations, and integration with the existing profile system.
- Add comprehensive proxy profile management with create and read operations
- Integrate proxy configurations into AMT profiles with priority-based ordering
- Implement database schema and operations for proxy profile storage
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/constants.ts | Code style formatting changes from single to double quotes |
| src/routes/admin/proxies/ | New proxy API endpoints with validation and CRUD operations |
| src/models/ | Extended data models to support proxy configurations |
| src/interfaces/database/ | New database interfaces for proxy profile operations |
| src/data/postgres/tables/ | Database implementation for proxy profile storage and relationships |
| data/init.sql | Database schema for proxy configurations and profile associations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
madhavilosetty-intel
force-pushed
the
get-post-http-proxy
branch
3 times, most recently
from
August 13, 2025 19:03
bf5f561 to
6500fb2
Compare
madhavilosetty-intel
changed the title
berosaso
force-pushed
the
get-post-http-proxy
branch
5 times, most recently
from
August 15, 2025 07:48
484cece to
73828d2
Compare
berosaso
force-pushed
the
get-post-http-proxy
branch
from
August 15, 2025 17:45
a425614 to
7605988
Compare
berosaso
force-pushed
the
get-post-http-proxy
branch
from
August 24, 2025 04:10
6842bbd to
f19d0a2
Compare
berosaso
changed the title
rsdmike
requested changes
Aug 25, 2025
| } | ||
|
|
||
| if (amtConfig.proxyConfigs) { | ||
| if (amtConfig.proxyConfigs?.length > 0) { |
Member
There was a problem hiding this comment.
the question mark already checks if proxyConfigs is null or undefined, so remove if condition on 273 as it is redundant
Contributor
Author
There was a problem hiding this comment.
Hi @rsdmike , tried to remove line 273 but it complains about the following:
Same case for all other comments about the same topic. BTW, I took as reference code on line 263.
| amtConfig.tenantId | ||
| ) | ||
| } | ||
| if (amtConfig.proxyConfigs && amtConfig.proxyConfigs?.length > 0) { |
Member
There was a problem hiding this comment.
same comment here, ? already checks null/undefined
| [accessInfo, tenantId] | ||
| ) | ||
|
|
||
| if (results?.rowCount) { |
| [accessInfo, tenantId] | ||
| ) | ||
|
|
||
| if (results?.rowCount) { |
| proxyConfig.tenantId | ||
| ] | ||
| ) | ||
| if (results?.rowCount) { |
| ) | ||
|
|
||
| latestItem = await this.getByName(proxyConfig.accessInfo, proxyConfig.tenantId) | ||
| if (results?.rowCount) { |
| [configName, tenantId] | ||
| ) | ||
|
|
||
| if (deleteProfileWifiResults?.rowCount) { |
| ) | ||
| ) | ||
|
|
||
| if (proxyProfilesQueryResults?.rowCount) { |
| [tenantId] | ||
| ) | ||
| let count = 0 | ||
| if (result != null && result.rows?.length > 0) { |
Member
There was a problem hiding this comment.
nit: if (result?.rows?.length > 0) {
| [accessInfo, tenantId] | ||
| ) | ||
| if (profiles?.rowCount) { | ||
| if (profiles.rowCount > 0) { |
berosaso
force-pushed
the
get-post-http-proxy
branch
from
August 26, 2025 00:26
1937247 to
eaa5a23
Compare
jaolanlo
force-pushed
the
get-post-http-proxy
branch
from
August 26, 2025 00:48
eaa5a23 to
b91c7fe
Compare
rsdmike
approved these changes
Aug 26, 2025
|
🎉 This PR is included in version 2.28.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covering create and select all operations
PR Checklist
What are you changing?
Creating endpoints to support get all and create operations, for http proxies linked to a profile
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )