Skip to content

refactor: add http get, update and delete endpoints#2306

Merged
madhavilosetty-intel merged 1 commit into
device-management-toolkit:mainfrom
sfmadrig:get-delete-update-http-proxy
Sep 30, 2025
Merged

refactor: add http get, update and delete endpoints#2306
madhavilosetty-intel merged 1 commit into
device-management-toolkit:mainfrom
sfmadrig:get-delete-update-http-proxy

Conversation

@sfmadrig

@sfmadrig sfmadrig commented Sep 1, 2025

Copy link
Copy Markdown
Contributor
  • Covering get single, update, and delete operations
  • Small corrections on create and update operations

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

@sfmadrig
sfmadrig force-pushed the get-delete-update-http-proxy branch from ae292ef to 0507650 Compare September 5, 2025 17:09
@sfmadrig
sfmadrig marked this pull request as ready for review September 5, 2025 17:10
@sfmadrig
sfmadrig force-pushed the get-delete-update-http-proxy branch from 0507650 to 49c131d Compare September 8, 2025 17:43
@jaolanlo
jaolanlo requested review from Copilot and rsdmike September 8, 2025 18:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@sfmadrig
sfmadrig force-pushed the get-delete-update-http-proxy branch 3 times, most recently from 61c536e to a2d6b99 Compare September 23, 2025 22:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/routes/admin/proxy/proxyValidator.ts Outdated
Comment thread src/routes/admin/proxy/proxyValidator.ts
Comment thread src/routes/admin/proxy/edit.ts Outdated
Comment thread src/routes/admin/proxy/edit.ts Outdated
Comment thread src/routes/admin/proxy/edit.ts Outdated
Comment thread src/routes/admin/proxy/get.test.ts Outdated
Comment thread src/routes/admin/proxy/get.test.ts Outdated
Comment thread src/routes/admin/proxy/delete.test.ts
@sfmadrig
sfmadrig force-pushed the get-delete-update-http-proxy branch 4 times, most recently from bfd7259 to 30f102a Compare September 24, 2025 22:17
@sfmadrig
sfmadrig requested a review from jaolanlo September 25, 2025 16:09
@sfmadrig
sfmadrig force-pushed the get-delete-update-http-proxy branch 3 times, most recently from 7484f8a to 86771e0 Compare September 25, 2025 20:59
Comment thread src/routes/admin/proxy/delete.ts
@sfmadrig
sfmadrig force-pushed the get-delete-update-http-proxy branch 2 times, most recently from d223f9e to da67b25 Compare September 26, 2025 19:15
@madhavilosetty-intel
madhavilosetty-intel enabled auto-merge (squash) September 26, 2025 19:57
@sfmadrig
sfmadrig force-pushed the get-delete-update-http-proxy branch 2 times, most recently from f7df075 to 0307df4 Compare September 26, 2025 20:34
  - Covering get single, update, and delete operations
  - Small corrections on create and update operations
  - Adding Postman API tests
  - Updating swagger
@sfmadrig
sfmadrig force-pushed the get-delete-update-http-proxy branch from 0307df4 to 5e54daf Compare September 30, 2025 16:36
@madhavilosetty-intel
madhavilosetty-intel merged commit 60db419 into device-management-toolkit:main Sep 30, 2025
9 checks passed
@RosieAMT

RosieAMT commented Oct 8, 2025

Copy link
Copy Markdown

🎉 This PR is included in version 2.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants